Flaky test: PrintPreviewDestinationSettingsTest.ChangeButtonState Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/54191 Test output log: https://chromium-swarm.appspot.com/task?id=4129937d46306010 Culprit (100.0% confidence): r607896 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKEAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpKDMyKS81NDE5MS9icm93c2VyX3Rlc3RzL1VISnBiblJRY21WMmFXVjNSR1Z6ZEdsdVlYUnBiMjVUWlhSMGFXNW5jMVJsYzNRdVEyaGhibWRsUW5WMGRHOXVVM1JoZEdVPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PrintPreviewDestinationSettingsTest.ChangeButtonState&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKEAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpKDMyKS81NDE5MS9icm93c2VyX3Rlc3RzL1VISnBiblJRY21WMmFXVjNSR1Z6ZEdsdVlYUnBiMjVUWlhSMGFXNW5jMVJsYzNRdVEyaGhibWRsUW5WMGRHOXVVM1JoZEdVPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66a63dc5a18cb513b856528e3acdcb9e8acff050 commit 66a63dc5a18cb513b856528e3acdcb9e8acff050 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Nov 14 06:16:20 2018 Revert "Print Preview Refresh: Enable change button while destination loads" This reverts commit 9f695d7249c926ddde8515ce5e7bf8505addecc3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607896 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWY2OTVkNzI0OWM5MjZkZGRlODUxNWNlNWU3YmY4NTA1YWRkZWNjMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/54191 Sample Failed Step: browser_tests Sample Flaky Test: PrintPreviewDestinationSettingsTest.ChangeButtonState Original change's description: > Print Preview Refresh: Enable change button while destination loads > > In some cases (e.g. kiosk apps with no default printer configured), the > print destination may never load. Enable the "Change" button while > destination capabilities are loading so that the user can switch > destinations in this case. > > Bug: 901115 > Change-Id: I53eec9332e0d7f075e461226290d408ae6d6ef49 > Reviewed-on: https://chromium-review.googlesource.com/c/1332703 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607896} Change-Id: I67b37b31938b6af5c19edc09a1e66b9019d0e198 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901115, 905205 Reviewed-on: https://chromium-review.googlesource.com/c/1335278 Cr-Commit-Position: refs/heads/master@{#607919} [modify] https://crrev.com/66a63dc5a18cb513b856528e3acdcb9e8acff050/chrome/browser/resources/print_preview/new/destination_settings.html [modify] https://crrev.com/66a63dc5a18cb513b856528e3acdcb9e8acff050/chrome/browser/resources/print_preview/new/destination_settings.js [delete] https://crrev.com/78e17bee9c2e5139fb675d08e3527a6e138f3fe4/chrome/test/data/webui/print_preview/destination_settings_test.js [modify] https://crrev.com/66a63dc5a18cb513b856528e3acdcb9e8acff050/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [modify] https://crrev.com/66a63dc5a18cb513b856528e3acdcb9e8acff050/testing/buildbot/filters/webui_polymer2_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d31eecb71020893b067a2b48a9efd45d91f2b2cb commit d31eecb71020893b067a2b48a9efd45d91f2b2cb Author: rbpotter <rbpotter@chromium.org> Date: Thu Nov 15 22:26:35 2018 Reland tests for Print Preview: Enable change button during load Flakes appear to be due to destination store communicating with the real native layer/print preview handler. Stub out native layer like in other tests. Bug: 901115, 905205 Change-Id: I938b6fbecfc5da26a5495e6f9ecbb8fa35b64d4e Reviewed-on: https://chromium-review.googlesource.com/c/1335998 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#608548} [add] https://crrev.com/d31eecb71020893b067a2b48a9efd45d91f2b2cb/chrome/test/data/webui/print_preview/destination_settings_test.js [modify] https://crrev.com/d31eecb71020893b067a2b48a9efd45d91f2b2cb/chrome/test/data/webui/print_preview/native_layer_stub.js [modify] https://crrev.com/d31eecb71020893b067a2b48a9efd45d91f2b2cb/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [modify] https://crrev.com/d31eecb71020893b067a2b48a9efd45d91f2b2cb/testing/buildbot/filters/webui_polymer2_browser_tests.filter
Comment 1 by bugdroid1@chromium.org
, Nov 14