New issue
Advanced search Search tips

Issue 905196 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

21.7% regression in blink_perf.shadow_dom at 606760:606772

Project Member Reported by chiniforooshan@chromium.org, Nov 14

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=905196

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=93752038ab585e171b1b4278fd163430058891307d3fe3affddcaad1207ee11d


Bot(s) for this bug's original alert(s):

mac-10_13_laptop_high_end-perf

blink_perf.shadow_dom - Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Cc: rakina@chromium.org
Owner: rakina@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/112652e3e40000

Add assigned_nodes_index_ map for slot's assigned child by rakina@chromium.org
https://chromium.googlesource.com/chromium/src/+/eaddcb2899f1120b8a8d4d30d3c2a2911e65d049
v1-large-shallow-distribution: 1.18 → 1.443 (+0.2625)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Labels: -Pri-2 Pri-1
This can be a perf regression. P2 -> P1.
Cc: hirosh...@chromium.org
 Issue 905197  has been merged into this issue.
hayato@, is this regression fixed by your recent Flat tree traversal CLs?
Owner: hayato@chromium.org
Status: Fixed (was: Assigned)
Yes, as far as I can read from the graph, my CL [1] fixed the regression caused by this CL [2].

- [1] https://chromium-review.googlesource.com/c/chromium/src/+/1337225
- [2] https://chromium-review.googlesource.com/c/chromium/src/+/1328622

Sign in to add a comment