New issue
Advanced search Search tips

Issue 905189 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 905918
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

31.2% regression in rendering.desktop/percentage_smooth at 606620:606663

Project Member Reported by chiniforooshan@chromium.org, Nov 14

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=905189

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0844d8a7d98f062413da61f9cdb882458a279486ddffadfb5784678b55ca58b3


Bot(s) for this bug's original alert(s):

linux-perf

rendering.desktop - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: pbos@chromium.org
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12a1517be40000

Remove TabIcon from a layer after animations end by pbos@chromium.org
https://chromium.googlesource.com/chromium/src/+/ceb3938769495604041e416b21f7c2a3989539a0
percentage_smooth: 71.67 → 33.45 (-38.21)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c65b08a1d44375e034ee693649bc923b179799e9

commit c65b08a1d44375e034ee693649bc923b179799e9
Author: Peter Boström <pbos@chromium.org>
Date: Wed Nov 14 16:10:17 2018

Don't schedule UI updates on load progress

The load-progress animation is driven off a timer that starts in
LoadingStateChanged and progresses without scheduling another update.

This is a likely cause for performance regressions as all load progress
updates (even ones without UI changes) will hammer this function.

Bug:  chromium:905189 ,  chromium:903147 ,  chromium:901751 
Change-Id: I92828bbaee6f15fc497ae50ec0d4c3975e638a86
Reviewed-on: https://chromium-review.googlesource.com/c/1335948
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607996}
[modify] https://crrev.com/c65b08a1d44375e034ee693649bc923b179799e9/chrome/browser/ui/browser.cc
[modify] https://crrev.com/c65b08a1d44375e034ee693649bc923b179799e9/chrome/browser/ui/browser.h

Mergedinto: 905918
Status: Duplicate (was: Assigned)

Sign in to add a comment