New issue
Advanced search Search tips

Issue 905188 link

Starred by 1 user
Status: WontFix
Owner:
hayato@chromium.org
Closed: Jan 15
Cc:
chiniforooshan@chromium.org
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

22.3% regression in blink_perf.shadow_dom at 606112:607097

Project Member Reported by chiniforooshan@chromium.org, Nov 14 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 14 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=905188

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b004bd39bdd651416e1baf4df0e5ddd29163b339d10c96f9b65965fde609f279


Bot(s) for this bug's original alert(s):

Android Nexus5 Perf

blink_perf.shadow_dom - Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks

Comment 5 by fergal@chromium.org, Jan 10 

Pinpoint job is full of timeouts. Requesting another run, hopefully it will point a change. Also, performance seems to have reverted back to normal a while later. I've requested a pin point for that too. Hopefully things will make sense.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jan 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/15a2da25940000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTaskError: The swarming task failed with state "BOT_DIED".
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jan 11

Cc: hayato@chromium.org
Owner: hayato@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11f18e83940000

Make flat tree traversal faster by hayato@chromium.org
https://chromium.googlesource.com/chromium/src/+/d2277a1c525c6cac5cfb065a71fbb625adf5dd53
v1-mutate-shallow-tree-then-slot-flatten: 247.8 → 216.9 (-30.86)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks

Comment 9 by hayato@chromium.org, Jan 15

Status: WontFix (was: Assigned)
It looks that this is an expected perf change by the flat tree traversal behavior change.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago) 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14cc18c0540000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTaskError: The swarming task failed with state "BOT_DIED".
►

Sign in to add a comment