New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905151 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Update unittests to support kMultiDeviceApi flag being enabled-by-default

Project Member Reported by hansberry@chromium.org, Nov 14

Issue description

These tests [1] need the kMultiDeviceApi flag to be disabled in order to pass. They need to be changed to support the kMultiDeviceApi flag being enabled, because as-is they do not reflect how the code is run in production in M71.

1) https://cs.chromium.org/search/?q=%22InitAndDisableFeature(features::kMultiDeviceApi)%22&type=cs
 
Tests that need to be addressed:

KeepAliveOperationTest
KeepAliveSchedulerTest
HostScannerOperationTest
HostScannerImplTest
TetherConnectorImplTest
ConnectTetheringOperationTest
DisconnectTetheringOperationTest
HostConnectionMetricsLoggerTest
DisconnectTetheringRequestSenderTest
ConnectTetheringRequestSenderTest

As far as I can tell, these will fail as-is once the kMultiDeviceApi flag is enabled because they do not fully initialize their FakeDeviceSyncClient and FakeSecureChannelClient objects. 

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a73bb31594cd5e2aa64817f803ec057d0badcaa6

commit a73bb31594cd5e2aa64817f803ec057d0badcaa6
Author: Regan Hsu <hsuregan@chromium.org>
Date: Thu Nov 15 19:29:57 2018

[CrOS MultiDevice] Remove MessageTransferOperation kMultiDeviceApi references.

We are launching the new multi-device services and removing
the old functionality.  As part of the internal cleanup, we
are removing references to kMultiDeviceApi from
MessageTransferOperation - as the functionality it entails
will become the default action - and removing code that
relies on old methods.

Many of the tests that rely on fake classes that mimic old
functionality fail.  As a result, this CL disables those tests.

Bug: 905151

Change-Id: I9ad4572431afe9e659e1a82edf878b09d3734367
Reviewed-on: https://chromium-review.googlesource.com/c/1328163
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608474}
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/host_scanner_impl_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/message_transfer_operation.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/message_transfer_operation.h
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/a73bb31594cd5e2aa64817f803ec057d0badcaa6/chromeos/components/tether/tether_connector_impl_unittest.cc

Labels: Enterprise-Triaged

Sign in to add a comment