New issue
Advanced search Search tips

Issue 905136 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Picture-in-Picture] Hide play/pause window button for video with infinity duration.

Project Member Reported by fbeaufort@chromium.org, Nov 14

Issue description

MediaStream video in PiP don't have a play/pause button as it's considered "live" content. We should do the same for regular "video src=" if video duration is Infinity.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb68c43eeecdd91b8a1665bb73c197d04a9f2ae1

commit bb68c43eeecdd91b8a1665bb73c197d04a9f2ae1
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Nov 20 20:12:03 2018

[Picture-in-Picture] Hide play/pause button if video duration is Infinity

This makes sure Picture-in-Picture window doesn't show play/pause button
if video duration is infinity like we do already for mediastream video.

Bug:  905136 
Change-Id: Iec193e8807a756f51fec6efd4d446fa65e2df71b
Reviewed-on: https://chromium-review.googlesource.com/c/1328963
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#609785}
[modify] https://crrev.com/bb68c43eeecdd91b8a1665bb73c197d04a9f2ae1/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/bb68c43eeecdd91b8a1665bb73c197d04a9f2ae1/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/bb68c43eeecdd91b8a1665bb73c197d04a9f2ae1/media/blink/webmediaplayer_impl_unittest.cc

Status: Verified (was: Started)
Verified in Chromium 72.0.36.18.0
Labels: Merge-Request-71
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 21

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
As we're aiming to ship Picture-in-Picture for MediaStream video in M71, this change would greatly be welcome in M71. It is simply about hiding a play/pause button in the Picture-in-Picture window.

Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comments #2, #5 and per offline chat  fbeaufort@, this feature is behind finch and change is fully safe.
Cc: mlamouri@chromium.org
Mounir, can you proceed to the merge?
I get a merge conflict when doing it from the Gerrit UI.

Comment 8 Deleted

Pls merge only if it is fully safe to merge after resolving merge conflict and monitor continuous beta builders after the merge. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 22

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b6c8da125654e265480847f40a7fa57bb389f9

commit 57b6c8da125654e265480847f40a7fa57bb389f9
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Thu Nov 22 08:52:20 2018

[Picture-in-Picture] Hide play/pause button if video duration is Infinity

This makes sure Picture-in-Picture window doesn't show play/pause button
if video duration is infinity like we do already for mediastream video.

TBR=beaufort.francois@gmail.com

(cherry picked from commit bb68c43eeecdd91b8a1665bb73c197d04a9f2ae1)

Bug:  905136 
Change-Id: Iec193e8807a756f51fec6efd4d446fa65e2df71b
Reviewed-on: https://chromium-review.googlesource.com/c/1328963
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Original-Commit-Position: refs/heads/master@{#609785}
Reviewed-on: https://chromium-review.googlesource.com/c/1347358
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/branch-heads/3578@{#796}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/57b6c8da125654e265480847f40a7fa57bb389f9/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/57b6c8da125654e265480847f40a7fa57bb389f9/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/57b6c8da125654e265480847f40a7fa57bb389f9/media/blink/webmediaplayer_impl_unittest.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/57b6c8da125654e265480847f40a7fa57bb389f9

Commit: 57b6c8da125654e265480847f40a7fa57bb389f9
Author: beaufort.francois@gmail.com
Commiter: beaufort.francois@gmail.com
Date: 2018-11-22 08:52:20 +0000 UTC

[Picture-in-Picture] Hide play/pause button if video duration is Infinity

This makes sure Picture-in-Picture window doesn't show play/pause button
if video duration is infinity like we do already for mediastream video.

TBR=beaufort.francois@gmail.com

(cherry picked from commit bb68c43eeecdd91b8a1665bb73c197d04a9f2ae1)

Bug:  905136 
Change-Id: Iec193e8807a756f51fec6efd4d446fa65e2df71b
Reviewed-on: https://chromium-review.googlesource.com/c/1328963
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Original-Commit-Position: refs/heads/master@{#609785}
Reviewed-on: https://chromium-review.googlesource.com/c/1347358
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/branch-heads/3578@{#796}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
I've monitored continuous beta builders after this merge and they do not fail because of this merge. I think we're good then.

Sign in to add a comment