Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you.

Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.

It is too late for M71 strings changes. Can this be targeted to M72?

Those are not string changes. The string have landed and all. The bug is that we had two different feature flags for two different features and the new strings were behind the wrong flag. The change is fairly small and the strings are already in code. It's only changing which feature flag we use to show which string.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e332bb109c56189a8593706d7b5ade60f613e48d

commit e332bb109c56189a8593706d7b5ade60f613e48d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Nov 15 23:26:14 2018

Autoplay: change feature flags associated with string changes.

Bug:  905128 
Change-Id: I590981ee93a645cef51586c880b5225ab03f2c29
Reviewed-on: https://chromium-review.googlesource.com/c/1335028
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608573}
[modify] https://crrev.com/e332bb109c56189a8593706d7b5ade60f613e48d/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/e332bb109c56189a8593706d7b5ade60f613e48d/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/e332bb109c56189a8593706d7b5ade60f613e48d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/e332bb109c56189a8593706d7b5ade60f613e48d/chrome/test/data/webui/settings/site_details_permission_tests.js

Confirming fixed on Canary, merged.

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 8b250d909c07f5aa3df8394646421721cb442520 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/8b250d909c07f5aa3df8394646421721cb442520

Commit: 8b250d909c07f5aa3df8394646421721cb442520
Author: mlamouri@chromium.org
Commiter: mlamouri@chromium.org
Date: 2018-11-16 20:03:23 +0000 UTC

Autoplay: change feature flags associated with string changes.

Bug:  905128 
Change-Id: I590981ee93a645cef51586c880b5225ab03f2c29
Reviewed-on: https://chromium-review.googlesource.com/c/1335028
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#608573}(cherry picked from commit e332bb109c56189a8593706d7b5ade60f613e48d)
Reviewed-on: https://chromium-review.googlesource.com/c/1340867
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#736}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b250d909c07f5aa3df8394646421721cb442520

commit 8b250d909c07f5aa3df8394646421721cb442520
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Nov 16 20:03:23 2018

Autoplay: change feature flags associated with string changes.

Bug:  905128 
Change-Id: I590981ee93a645cef51586c880b5225ab03f2c29
Reviewed-on: https://chromium-review.googlesource.com/c/1335028
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#608573}(cherry picked from commit e332bb109c56189a8593706d7b5ade60f613e48d)
Reviewed-on: https://chromium-review.googlesource.com/c/1340867
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#736}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/8b250d909c07f5aa3df8394646421721cb442520/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/8b250d909c07f5aa3df8394646421721cb442520/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/8b250d909c07f5aa3df8394646421721cb442520/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/8b250d909c07f5aa3df8394646421721cb442520/chrome/test/data/webui/settings/site_details_permission_tests.js

mlamouri@, this change got merged to M71 without merge request and approval. As you already answered at #4, this is ok but next time pls request a merge to M71. Thank you.

This was discussed over email I believe. You mention to merge ASAP after tested on Canary. It was my understanding that I could use this as approval. Should I ask for an approval on the bug next time this happens?

My apologies. Reading trough the email again, I misread and it indeed asked for me to request a merge, not merge directly.

Ah, sorry about that. Next time, pls request a merge. Thank you.

No worries all good, thank you.