Return IPv6 addresses from dnsResolve() and myIpAddress() |
|
Issue descriptionChrome currently matches Microsoft (but not Mozilla) in its interpretation of dnsResolve() and myIpAddress(). Notably, these functions are limited to returning IPv4 results. This approach is problematic when the result only contains IPv6 addresses, as we have nothing to return, and not all PAC scripts are using the *Ex() variants. We should be able to slightly change our policy without causing compatibility problems: Pick an IPv4 address if there is one, otherwise return an IPv6 address. With this new policy, PAC scripts would continue working as they did in most cases. However in the case where the only results were IPv6, we would return something rather than failing.
,
Jan 2
Hi, I have tested both dnsResolve() and myIpAddress(), but can't reproduce the issue: My setup: OS: Win10 with IPv6 stack only. Chromium 73.0.3644.0 (Developer Build) (64-bit) Revision e009db17ad54fe47cf396bc7efcc4c9553bf0ffe-refs/heads/master@{#617319} OS Windows JavaScript V8 7.3.168 Results: 1) myIpAddress() in all my tests myIpAddress() always returns IPv6 address correctly. per my understanding of [1] if the finding of own IP is not successful the IPv4 loopback (127.0.0.1) address will be returned. 2) dnsResolve() The code [2] is not successful, however in [1] we set a return value to 'null' and return it. Please let me if I miss anything and if you want me to continue working on this issue. [1] https://cs.chromium.org/chromium/src/net/proxy_resolution/proxy_resolver_v8.cc?l=765&rcl=fa268a7a6e851af5da4577f04284f2eacfba93b4 [2] https://cs.chromium.org/chromium/src/net/proxy_resolution/proxy_resolver_v8.cc?l=751&rcl=fa268a7a6e851af5da4577f04284f2eacfba93b4 |
|
►
Sign in to add a comment |
|
Comment 1 by eug...@sudin.pro
, Dec 5