New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 905122 link

Starred by 2 users
Status: Fixed
Owner:
yyanagisawa@chromium.org
Closed: Nov 22
Cc:
█ raphael....@intel.com
ukai@chromium.org
tikuta@chromium.org
yyanagisawa@chromium.org
shinyak@chromium.org
sque@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

make goma_auth.py also respects environment variables for HTTP proxy.

Project Member Reported by yyanagisawa@google.com, Nov 14 
Currently, Goma client use GOMA_PROXY_HOST and GOMA_PROXY_PORT to specify which HTTP Proxy should be used.  It requires the users to manually set HTTP proxy configs for Goma client.

goma_ctl.py automatically translate http proxy environment to Goma's but goma_auth.py do not.  Let's make goma_auth.py understand such environment variables.

Comment 1 by yyanagisawa@google.com, Nov 14 

But stepping back,...
We usually do not make our python script depends on non-system python modules.  At the same time, I prefer to avoid code duplication.
It it reasonable to make http_init.cc also understand the environment variables?

Comment 2 by yyanagisawa@google.com, Nov 14

Labels: -Type-Bug Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/goma/client/+/c21fa4a3e1486c468f179a59ddb2c81f9643ad2b

commit c21fa4a3e1486c468f179a59ddb2c81f9643ad2b
Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Date: Thu Nov 15 08:10:15 2018
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/goma/client/+/3d62485d3ef1a47dc9ae42850a98a5b5f78fef12

commit 3d62485d3ef1a47dc9ae42850a98a5b5f78fef12
Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Date: Fri Nov 16 07:48:22 2018

Comment 5 by yyanagisawa@chromium.org, Nov 20

Owner: yyanagisawa@chromium.org

Comment 6 by yyanagisawa@chromium.org, Nov 20

Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/goma/client/+/2532a1c59a7aab5d716d6723d0daad46b3f50fe0

commit 2532a1c59a7aab5d716d6723d0daad46b3f50fe0
Author: Yoshisato Yanagisawa <yyanagisawa@google.com>
Date: Tue Nov 20 06:17:42 2018

Comment 8 by raphael....@intel.com, Nov 22 

I guess this is fixed? I've updated to the latest client (a81cdacab5f3977aad13daee5405399070e9f588) and managed to use goma_auth.py {info,login,logout} without having to set GOMA_PROXY_{HOST,PORT}.

Comment 9 by yyanagisawa@chromium.org, Nov 22

Status: Fixed (was: Started)
Yes.
►

Sign in to add a comment