New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 905120 link

Starred by 2 users
Status: Fixed
Owner:
█ dim...@chromium.org
Last visit > 30 days ago
Closed: Nov 27
Cc:
dewittj@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Need to create ExploreSitesService unconditionally when BrowserContext is created.

Project Member Reported by dimich@google.com, Nov 14 
ExploreSitesService is not added to Dependency Manager initialization so it is not created with BrowserContext, but rather on demand. This results in not getting UMA for not-enabled (Control) group of the users since nothing requests the service.

By design, this service is a top object that collectd dependencies but initializes heavy resources lazily on-demand.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07ec2fa2379032bc041f466fbd635dec09a27b69

commit 07ec2fa2379032bc041f466fbd635dec09a27b69
Author: Dmitry Titov <dimich@chromium.org>
Date: Tue Nov 27 02:22:16 2018

Add ExploreSitesService to dependency manager.

ExploreSitesService is a lightweight object that lazily initiates heavier resources on demand.
Currently, it is created by UI (NTP page being open), however it starts subsequent
background activities (refreshing the catalog of sites, and collectingusage statistics)
so it should be started even if UI does not require it. This CL adds the service to dependency
manager list so it is created early in the initialization of Profile.

Bug:  905120 
Change-Id: I63c30decd2bc9e70729438cc06a596089efcd585
Reviewed-on: https://chromium-review.googlesource.com/c/1334936
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610996}
[modify] https://crrev.com/07ec2fa2379032bc041f466fbd635dec09a27b69/chrome/browser/android/explore_sites/explore_sites_service_factory.cc
[modify] https://crrev.com/07ec2fa2379032bc041f466fbd635dec09a27b69/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/07ec2fa2379032bc041f466fbd635dec09a27b69/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/07ec2fa2379032bc041f466fbd635dec09a27b69/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
[modify] https://crrev.com/07ec2fa2379032bc041f466fbd635dec09a27b69/chrome/browser/android/explore_sites/history_statistics_reporter.cc
[modify] https://crrev.com/07ec2fa2379032bc041f466fbd635dec09a27b69/chrome/browser/android/explore_sites/history_statistics_reporter.h
[modify] https://crrev.com/07ec2fa2379032bc041f466fbd635dec09a27b69/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

Comment 2 by dim...@chromium.org, Nov 27

Status: Fixed (was: Started)
►

Sign in to add a comment