New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 905119 link

Starred by 2 users
Status: Fixed
Owner:
kristip...@chromium.org
Closed: Nov 20
Cc:
yyushkina@chromium.org
█ ramyan@chromium.org
jmukthavaram@chromium.org
bklmn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Improve transitions of the shortcut tiles

Project Member Reported by kristip...@chromium.org, Nov 14 
Currently, the tiles "flash" when adding/removing/editing links (i.e. the MV section is briefly blank before the new tiles appear). This is because the old tiles are immediately hidden before the new tiles fade in.

Improve the tile transition by fading out the old tiles as the new tiles are fading in.

Comment 1 by kristip...@chromium.org, Nov 14

Components: UI>Browser>NewTabPage
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/857f4dd86add8b3f795772837969a6d699dd286a

commit 857f4dd86add8b3f795772837969a6d699dd286a
Author: Kristi Park <kristipark@chromium.org>
Date: Wed Nov 14 19:04:16 2018

[NTP] Remove 'white flash' transition from MV tiles

Use smoother transition when the MV tiles are updated. This removes the
'white flash' that is currently present.

Screencast: https://screencast.googleplex.com/cast/NTM0NjkzNjMyNDM1ODE0NHxhZWM4ZWEyOS04MA

Bug:  905119 
Change-Id: Ic1a7ea35b2e05bbcbcd583b2ca792a6b7c8f2dc0
Reviewed-on: https://chromium-review.googlesource.com/c/1334938
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608071}
[modify] https://crrev.com/857f4dd86add8b3f795772837969a6d699dd286a/chrome/browser/resources/local_ntp/most_visited_single.css

Comment 3 by kristip...@chromium.org, Nov 15

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 4 by jmukthavaram@chromium.org, Nov 15

Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Tested this issue on windows 10 & Mac using chrome reported version-72.0.3608.0  & latest canary-72.0.3611.0 as per C#0 & fix in C#2 screen cast.

Observed same behavior(tiles white flash for the tiles) on both reported and canary versions. Please find the attached screen cast and let us know the clear steps to check this issue from TE end.
Thanks..!
905119-Reported.mp4
2.3 MB View Download
905119-latest canary-72.0.3611.0.mp4
2.8 MB View Download

Comment 5 by kristip...@chromium.org, Nov 15

Description: Show this description

Comment 6 by kristip...@chromium.org, Nov 15

Labels: -Needs-Feedback
Apologies for the confusion, I've updated the description for more clarity. The old tiles should now fade out instead of being immediately hidden, which removes the period where no tiles are shown on the NTP. The Canary screencast shows that this is working correctly.

Comment 7 by kristip...@chromium.org, Nov 20

Labels: Target-72
Status: Fixed (was: Started)

Comment 8 by jmukthavaram@google.com, Nov 27

Labels: TE-Verified-M72 TE-Verified-72.0.3611.0
Tested the same issue using chrome-72.0.3611.0 & latest canary-72.0.3622.0 on windows 10,mac, debian Rodate as per C#6 & adding TE Verified labels.

Please find the attached latest screencast.
Thanks..!
905119-latest canary-72.0.3622.0.mp4
14.3 MB View Download
►

Sign in to add a comment