New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905114 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add cross-link to Privacy settings page in Payments settings page.

Project Member Reported by se...@chromium.org, Nov 14

Issue description

This should only be present for when sync transport is enabled for wallet data.
 
Screenshot:
Screen Shot 2018-11-13 at 7.57.01 PM.png
136 KB View Download
Labels: -hotlist-butter butter-hotlist
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5bd0713b11036b62ebc8468a5bed3a48b767f5d

commit b5bd0713b11036b62ebc8468a5bed3a48b767f5d
Author: Sébastien Séguin-Gagnon <sebsg@chromium.org>
Date: Mon Nov 19 15:53:14 2018

[AF] Add cross-link to Privacy settings page in Payments settings page.

Bug:  905114 
Change-Id: Ib8300998f6f183d7ffd0378ada0fbf02f118b9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1308769
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609311}
[modify] https://crrev.com/b5bd0713b11036b62ebc8468a5bed3a48b767f5d/chrome/app/settings_strings.grdp
[modify] https://crrev.com/b5bd0713b11036b62ebc8468a5bed3a48b767f5d/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html
[modify] https://crrev.com/b5bd0713b11036b62ebc8468a5bed3a48b767f5d/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js
[modify] https://crrev.com/b5bd0713b11036b62ebc8468a5bed3a48b767f5d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/b5bd0713b11036b62ebc8468a5bed3a48b767f5d/chrome/test/data/webui/settings/payments_section_test.js
[modify] https://crrev.com/b5bd0713b11036b62ebc8468a5bed3a48b767f5d/components/autofill/core/common/autofill_constants.cc
[modify] https://crrev.com/b5bd0713b11036b62ebc8468a5bed3a48b767f5d/components/autofill/core/common/autofill_constants.h

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5e9e2c0a80c4f0b281155caca288e911ca2602c

commit e5e9e2c0a80c4f0b281155caca288e911ca2602c
Author: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Date: Mon Nov 19 21:24:55 2018

Revert "[AF] Add cross-link to Privacy settings page in Payments settings page."

This reverts commit b5bd0713b11036b62ebc8468a5bed3a48b767f5d.

Reason for revert: It was decided to roll-back this change.

Original change's description:
> [AF] Add cross-link to Privacy settings page in Payments settings page.
> 
> Bug:  905114 
> Change-Id: Ib8300998f6f183d7ffd0378ada0fbf02f118b9a2
> Reviewed-on: https://chromium-review.googlesource.com/c/1308769
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609311}

TBR=dpapad@chromium.org,sebsg@chromium.org

Change-Id: I100c8a76ca9dbd64aa4b6d0113dde027b9d47bf4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  905114 
Reviewed-on: https://chromium-review.googlesource.com/c/1343290
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609442}
[modify] https://crrev.com/e5e9e2c0a80c4f0b281155caca288e911ca2602c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/e5e9e2c0a80c4f0b281155caca288e911ca2602c/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html
[modify] https://crrev.com/e5e9e2c0a80c4f0b281155caca288e911ca2602c/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js
[modify] https://crrev.com/e5e9e2c0a80c4f0b281155caca288e911ca2602c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/e5e9e2c0a80c4f0b281155caca288e911ca2602c/chrome/test/data/webui/settings/payments_section_test.js
[modify] https://crrev.com/e5e9e2c0a80c4f0b281155caca288e911ca2602c/components/autofill/core/common/autofill_constants.cc
[modify] https://crrev.com/e5e9e2c0a80c4f0b281155caca288e911ca2602c/components/autofill/core/common/autofill_constants.h

It was decided to not add this link after all.

Sign in to add a comment