New issue
Advanced search Search tips

Issue 905095 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 840441



Sign in to add a comment

Remove Data Saver and Autoplay/Preloading Interaction

Project Member Reported by robertogden@chromium.org, Nov 14

Issue description

It has been decided that blocking muted autoplay when Data Saver is enabled should no longer be supported because it broke some sites and is no longer saving much data for our users.

This bug tracks the removal of that code as well as updating any public documentation.
 
Blockedon: 840441
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/304bca03503f89c8c671c10f36d9b8985af36918

commit 304bca03503f89c8c671c10f36d9b8985af36918
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Nov 14 18:56:49 2018

Enable media holdback experiment by default

Change-Id: Ibbdd75e179458b401f2e5ff3a61a415865769351
Bug:  905095 
Reviewed-on: https://chromium-review.googlesource.com/c/1335274
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608065}
[modify] https://crrev.com/304bca03503f89c8c671c10f36d9b8985af36918/chrome/browser/chrome_content_browser_client.cc

Cc: mlamouri@chromium.org beccahughes@chromium.org
Labels: OS-Android
Owner: tbansal@chromium.org
Status: Assigned (was: Untriaged)
Labels: M-72
Owner: robertogden@chromium.org
Labels: -M-72 M-73
The CL in comment#2 is past feature freeze, so I think it'd be best to aim for M73 on this.
M-73 seems reasonable. By default, the Chromium code in M-72 already removes the interaction between data saver and autoplay. There are still some code cleanups to do, but they can go in M-73.
Description: Show this description
Is there a reason for this to be RVG?
Labels: -Restrict-View-Google
Just for our own record (saw this in some other code review): We would also need to remove IDS_WEBSITE_SETTINGS_CATEGORY_AUTOPLAY_DISABLED_DATA_SAVER (and related site settings code) as part of this cleanup.
Issue 649784 has been merged into this issue.
Cc: pnangunoori@chromium.org liber...@chromium.org bengr@chromium.org chelamcherla@chromium.org
 Issue 898096  has been merged into this issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14

commit 0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14
Author: Robert Ogden <robertogden@chromium.org>
Date: Wed Dec 12 22:41:29 2018

Remove DataSaver and Autoplay+Preload Integration

This feature breaks pages and doesn't help users save much data
anymore. See bug for more detail.

This CL removes all references to the integration in UMA, Blink,
WebPrefs, and the Android UI.

Bug:  905095 
Change-Id: Id6a6a149ffa98f461c892948d5570e5543973ae8
Reviewed-on: https://chromium-review.googlesource.com/c/1363790
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616089}
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/content/public/common/web_preferences.cc
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/content/public/common/web_preferences.h
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/content/renderer/render_view_impl.cc
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/public/web/web_settings.h
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/renderer/core/exported/web_settings_impl.cc
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/renderer/core/exported/web_settings_impl.h
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/renderer/core/frame/settings.json5
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/renderer/core/html/media/autoplay_uma_helper.h
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/web_tests/http/tests/media/preload-conditions.html
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/third_party/blink/web_tests/media/autoplay-muted-conditions.html
[delete] https://crrev.com/60e52e75f2d89746fc05880b57708b3d8c352aa6/third_party/blink/web_tests/media/autoplay-muted-datasaver-off.html
[delete] https://crrev.com/60e52e75f2d89746fc05880b57708b3d8c352aa6/third_party/blink/web_tests/media/autoplay-muted-datasaver-on-holdback-on.html
[delete] https://crrev.com/60e52e75f2d89746fc05880b57708b3d8c352aa6/third_party/blink/web_tests/media/autoplay-muted-datasaver-on.html
[modify] https://crrev.com/0dc6e0ae892c12a0c3a3a59c746b5fe83b2e2b14/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment