vboot/make_dev_ssd.sh breaks after kernel partitions increased in size (which breaks deploy_chrome) |
||||||
Issue descriptionSee https://chromium-review.googlesource.com/c/chromium/src/+/1332725 Looks like all the tests that run deploy_chrome are failing. eg: https://chromium-swarm.appspot.com/task?id=4124f1265c44ea10 Error msg is: mount: /: cannot remount /dev/dm-0 read-write, is write-protected. Did something change wrt the mount points in the VM images?
,
Nov 14
s/remote/remove/
,
Nov 14
Partitions 2 and 4 grew from 16M to 64M in https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1318213/ But it looks like make_dev_ssd.sh doesn't like partitions greater than 32M: https://cs.corp.google.com/chromeos_public/src/platform/vboot_reference/scripts/image_signing/make_dev_ssd.sh?rcl=4c56ba267ecc722d929e7720789ea6183c54bd2a&l=159 Maybe that script needs updating?
,
Nov 14
> Maybe that script needs updating? Can we remove the check from the script? I don't really understand why we check for it. Looks to be an original line from hungte@ https://chromium.git.corp.google.com/chromiumos/platform/vboot_reference/+/20525b91644a786e966c9486ac9afdf3d7c5447f/scripts/image_signing/make_dev_ssd.sh
,
Nov 14
lets drop the check. we already have sanity later on when we try to actually parse the kernel format (such as trying to read the kernel cmdline and read/modify the vboot headers).
,
Nov 14
,
Nov 14
Ok. I'm traveling right now so it's a little hard to test this but here's the patch to remove the check for max size http://crrev.com/c/1336109 Note, I left the min size check because that seems fine to make sure there's something there.
,
Nov 15
It was added to quickly figure out if user is trying to apply a non-ChromeOS image (which was more easily seen at that time). Now I think it's fine to remove the size check.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/4586b0c1dea8af8fd603ee7f1a0f6271bdcc1963 commit 4586b0c1dea8af8fd603ee7f1a0f6271bdcc1963 Author: Stephen Boyd <swboyd@chromium.org> Date: Fri Nov 16 02:49:24 2018 image_signing: make_dev_ssd: Drop max kernel size check We recently expanded the kernel size from 16M to 64M for the generic amd64 image and that's causing problems for this script. Let's drop the check for a maximum size as we have other sanity checks for reading the kernel command line and modifying vboot headers later on anyway. BRANCH=None BUG= chromium:905093 TEST=deploy_chrome for amd64-generic image Change-Id: Id08ad0a1feb28fda850c611e1e993d15b32e502d Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1336109 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/4586b0c1dea8af8fd603ee7f1a0f6271bdcc1963/scripts/image_signing/make_dev_ssd.sh
,
Nov 29
Latest lkgm updates have successfully run deploy_chrome. Thanks for the timely fix! (Though the lkgm updates are still blocked by unrelated test failures. I'll track those elsewhere.) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bpastene@chromium.org
, Nov 14