New issue
Advanced search Search tips

Issue 905091 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Null-dereference READ in blink::AXObject::ComputedName

Project Member Reported by ClusterFuzz, Nov 14

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6252135123255296

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::AXObject::ComputedName
  blink::AXNodeObject::TextAlternative
  blink::AXLayoutObject::TextAlternative
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=607151:607152

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6252135123255296

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 14

Components: Blink>Accessibility
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 14

Labels: Test-Predator-Auto-Owner
Owner: aboxhall@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/e7316d0c2c1a3ea146197778d926502c9646e4bf (Prefer walking the LayoutTreeBuilder tree when building the Accessibility tree.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3681121fd387b017483102bfc3b17b8547bdd6fc

commit 3681121fd387b017483102bfc3b17b8547bdd6fc
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Tue Nov 20 05:20:15 2018

null check for AXObject for selectedOptions

This is showing up as a crash in AXNodeObject::TextAlternative(), which calls ComputedName() on each <option>'s accessibleNode.

Bug:  905091 
Change-Id: Ib3139b08e46eacd51a9f3e1cc6e376d9b6ab3d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1343398
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609602}
[modify] https://crrev.com/3681121fd387b017483102bfc3b17b8547bdd6fc/third_party/blink/renderer/modules/accessibility/ax_node_object.cc

Project Member

Comment 4 by ClusterFuzz, Nov 20

ClusterFuzz has detected this issue as fixed in range 609601:609602.

Detailed report: https://clusterfuzz.com/testcase?key=6252135123255296

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::AXObject::ComputedName
  blink::AXNodeObject::TextAlternative
  blink::AXLayoutObject::TextAlternative
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=607151:607152
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=609601:609602

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6252135123255296

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 20

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6252135123255296 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment