New issue
Advanced search Search tips

Issue 905090 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Merge Request: [UserTimingL3] Count values of parameters for User Timing APIs

Project Member Reported by maxlg@chromium.org, Nov 14

Issue description

UserTimingL3 introduces new features on top of UserTimingL2.

The L3 API augments the functionality of L2 API by allowing users to pass timestamps(number) and an extra javascript object to the API, in the places of two parameters that only took string name in L2. For example, a number passed in to the second parameter of measure API will be interpreted as a string in L2, but will be interpreted as a number in L3. More details about User Timing L3 can be found in the explainer: https://docs.google.com/document/d/1hltt8z9C4PaI5Qu1YMIp1wOGdbJPJPoJwBarEeCY6xQ/edit#heading=h.ejti6qhmjv0b

Because the L3 API will interpret the parameters differently, we need to investigate how much impact will the change cause to the current use cases in the wild.

As the L3 API will be launched soon, we need to investigate early enough to decide further changes are needed. A merge request to release branch will be needed to gather more data from the wild.
 
Labels: Merge-Request-71
Summary: Merge Request: [UserTimingL3] Count values of parameters for User Timing APIs (was: [UserTimingL3] Count values of parameters for User Timing APIs)
This is this CL we need to merge:
https://chromium-review.googlesource.com/c/chromium/src/+/1320012
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 14

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Affected OS: all the ones running Blink.
The CL is just adding logs to UMA. So only risk is unexpected crashes.
Is this M71 regression? Also how is the change looking canary?
Per comment #3, only risk is unexpected crashes. In this case, can this wait until M72 as we're very close to M71 stable promotion.
This is not a regression. This change is just to collect UMA data. It's fine to wait until M72. 

By the way, we haven't received UMA data in Canary yet. I think it would be safer to wait till any data comes in.
Labels: -Merge-Review-71 Merge-Rejected-71
Rejecting merge to M71 based on comment #5.
Status: WontFix (was: Started)
The gathered data looks satisfactory to make an initial decision about the real-world impact. As it's not urgent to collect more data, we don't need the merge request any more.

Marked as won't fixed.

Sign in to add a comment