New issue
Advanced search Search tips

Issue 905088 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Blocklist data may not be available at time of navigation start for Previews

Project Member Reported by tbansal@chromium.org, Nov 14

Issue description

Data from blocklist may not be available at the time of navigation start in the browser process for the very first navigation. This may be because the blocklist is read asynchronously from the disk. 

This may cause client side previews to not trigger for the very first navigation. One way to fix this may be to move the blocklist check from navigation  start to a little bit later (e.g., navigation commit).
 
The count of cases where blocklist data was unavailable at the time of nav. start is going up: https://screenshot.googleplex.com/2uon6EC0Dqy
Components: Blink>Previews
This is what I tried:

gn gen --args='is_component_build=true is_debug=true use_goma=true' out/out-gn3 &&   ninja -C out/out-gn3 -j500 -l20 chrome && out/out-gn3/chrome --enable-spdy-proxy-auth --force-effective-connection-type=2G cnn.com  > ~/log.log 2>&1

And, the blocklist was not available for the navigation to cnn.com.
This was an intentional decision, but I'd be happy to revisit it or add something like prefs to store some bad hosts, etc.
At least for client side previews, one solution is to defer checking of blacklist database to commit time (instead of navigation start).
Labels: -Pri-2 -M-72 Pri-3
This has really low impact based on UMA, so it is more of a nice to have unless we notice issues.

Comment 7 by tbansal@chromium.org, Jan 18 (4 days ago)

Status: WontFix (was: Assigned)

Sign in to add a comment