Bad overview mode state transition in tablet mode |
|||||||||
Issue descriptionLooks like the entering overview mode can trigger "ending" sequence. 1) Swtich to tablet moe 2) Have more than 2 windows. 3) go to home launcher screen 4) duble click the overview button RemoveAndDestroyAnimationObserver is invoked after ToggleOverview method, and calls OnEndingAnimationComplete
,
Nov 14
,
Nov 14
we'll have another 71 build today, so let's try to fix this.
,
Nov 15
,
Nov 15
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a1d18780f57accfc5d891a741bbd161e63b872 commit e6a1d18780f57accfc5d891a741bbd161e63b872 Author: Sammie Quon <sammiequon@google.com> Date: Thu Nov 15 00:31:59 2018 overview: Fixed bad overview mode state transition with double tap. Do not activate quick switch when double tapping the tray, if the mru window is not activate. This was causing an unexpected window activation which was messing up the overview state, and also visually popping up and activating an unexpected window. Test: Checked that OnEndingAnimation does not get called between ToggleOverview calls Bug: 905082 Change-Id: Iaa7d3d02482d33d27ade6684ece8b92e9c270204 Reviewed-on: https://chromium-review.googlesource.com/c/1336149 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608193} [modify] https://crrev.com/e6a1d18780f57accfc5d891a741bbd161e63b872/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/e6a1d18780f57accfc5d891a741bbd161e63b872/ash/system/overview/overview_button_tray_unittest.cc
,
Nov 15
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ab218f2b986925c5a7f4ee79210ab34979ea394 commit 6ab218f2b986925c5a7f4ee79210ab34979ea394 Author: Sammie Quon <sammiequon@google.com> Date: Thu Nov 15 01:05:52 2018 overview: Fixed bad overview mode state transition with double tap. Do not activate quick switch when double tapping the tray, if the mru window is not activate. This was causing an unexpected window activation which was messing up the overview state, and also visually popping up and activating an unexpected window. Test: Checked that OnEndingAnimation does not get called between ToggleOverview calls Bug: 905082 Change-Id: Iaa7d3d02482d33d27ade6684ece8b92e9c270204 Reviewed-on: https://chromium-review.googlesource.com/c/1336149 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608193}(cherry picked from commit e6a1d18780f57accfc5d891a741bbd161e63b872) Reviewed-on: https://chromium-review.googlesource.com/c/1336917 Cr-Commit-Position: refs/branch-heads/3578@{#687} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/6ab218f2b986925c5a7f4ee79210ab34979ea394/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/6ab218f2b986925c5a7f4ee79210ab34979ea394/ash/system/overview/overview_button_tray_unittest.cc
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ab218f2b986925c5a7f4ee79210ab34979ea394 Commit: 6ab218f2b986925c5a7f4ee79210ab34979ea394 Author: sammiequon@google.com Commiter: oshima@chromium.org Date: 2018-11-15 01:05:52 +0000 UTC overview: Fixed bad overview mode state transition with double tap. Do not activate quick switch when double tapping the tray, if the mru window is not activate. This was causing an unexpected window activation which was messing up the overview state, and also visually popping up and activating an unexpected window. Test: Checked that OnEndingAnimation does not get called between ToggleOverview calls Bug: 905082 Change-Id: Iaa7d3d02482d33d27ade6684ece8b92e9c270204 Reviewed-on: https://chromium-review.googlesource.com/c/1336149 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608193}(cherry picked from commit e6a1d18780f57accfc5d891a741bbd161e63b872) Reviewed-on: https://chromium-review.googlesource.com/c/1336917 Cr-Commit-Position: refs/branch-heads/3578@{#687} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 19
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by osh...@chromium.org
, Nov 13