New issue
Advanced search Search tips

Issue 905078 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix unrar_wrapper includes polluting top-level namespace

Project Member Reported by drubery@chromium.org, Nov 13

Issue description

unrar_wrapper.h creates a nice alias for Archive called ::third_party_unrar::Archive. Unfortunately, ::Archive still exists, polluting the top-level namespace. We should try not to introduce symbols in the top-level namespace.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0160f47fe100af4e08048edcc6ea111df38862e

commit a0160f47fe100af4e08048edcc6ea111df38862e
Author: Daniel Rubery <drubery@chromium.org>
Date: Wed Jan 09 16:24:57 2019

Add namespace third_party_unrar, to avoid polluting global namespace

Currently we have an unrar_wrapper.h that creates aliases of the global
symbols. This CL adds namespace declarations throughout the unrar code
so that we don't create nearly as many global symbols.

Bug:  905078 
Change-Id: Ic1d8b483eebb08f511fe4e3062497c1d65d5ed29
Reviewed-on: https://chromium-review.googlesource.com/c/1394867
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621171}
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/README.chromium
[add] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/patches/add_namespaces.patch
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/arccmt.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/archive.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/archive.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/arcmem.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/arcmem.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/arcread.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/array.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/blake2s.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/blake2s.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/blake2s_sse.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/blake2sp.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/cmddata.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/cmddata.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/coder.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/coder.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/consio.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/consio.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/crypt.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/crypt.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/crypt1.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/crypt2.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/crypt3.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/crypt5.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/errhnd.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/errhnd.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/extinfo.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/extinfo.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/extract.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/extract.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/filcreat.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/filcreat.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/file.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/file.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/filefn.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/filefn.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/filestr.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/filestr.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/find.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/find.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/global.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/hardlinks.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/hash.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/hash.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/headers.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/headers.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/list.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/list.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/log.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/log.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/match.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/match.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/model.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/model.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/options.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/options.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/pathfn.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/pathfn.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/qopen.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/qopen.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/rawread.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/rawread.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/rdwrfn.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/rdwrfn.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/recvol.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/recvol.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/recvol3.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/recvol5.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/resource.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/resource.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/savepos.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/scantree.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/scantree.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/secpassword.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/secpassword.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/strfn.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/strfn.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/strlist.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/strlist.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/suballoc.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/suballoc.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/system.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/system.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/threadmisc.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/threadpool.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/threadpool.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/timefn.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/timefn.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/ui.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/uicommon.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/uisilent.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/ulinks.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack15.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack20.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack30.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack50.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack50frag.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpack50mt.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unpackinline.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/unrar_wrapper.h
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/uowners.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/volume.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/volume.hpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/win32acl.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/win32lnk.cpp
[modify] https://crrev.com/a0160f47fe100af4e08048edcc6ea111df38862e/third_party/unrar/src/win32stm.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment