ECT estimate may not be available at time of navigation start for Previews |
|
Issue descriptionEffective connection type (ECT) estimate may not be available at the time of navigation start in the browser process for the very first navigation. This may be because network quality estimator in network process may not have read the prefs and/or sent the ECT change notification in-time to the network quality tracker (NQT) class in browser process. This may cause client side previews to not trigger for the very first navigation. One way to fix this may be to move the ECT check from navigation start to a little bit later (e.g., navigation commit).
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b89c1d51e0b97cef3e349599852d6f8b192d11f9 commit b89c1d51e0b97cef3e349599852d6f8b192d11f9 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Jan 16 06:56:29 2019 Previews: Move check for ECT at commit for optimization hints previews If the ECT is Unknown at navigation time, then currently we do not trigger the preview. This CL changes the logic to rather re-check the ECT at the commit time. If it's still UNKNOWN at the commit time, the preview is not triggered/committed. Change-Id: I37bbd30a4dd8f6308d308006a8beabc5a0768775 Bug: 905074 Reviewed-on: https://chromium-review.googlesource.com/c/1409856 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#623141} [modify] https://crrev.com/b89c1d51e0b97cef3e349599852d6f8b192d11f9/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/b89c1d51e0b97cef3e349599852d6f8b192d11f9/components/previews/content/previews_decider_impl.cc [modify] https://crrev.com/b89c1d51e0b97cef3e349599852d6f8b192d11f9/components/previews/content/previews_decider_impl_unittest.cc
,
Jan 18
(4 days ago)
This is fixed for the HTTPS previews for which the decision can be made at commit time (e.g., NoScript, Resource loading hints). Previews for which decision needs to be made at navigation start are still not fixed. Currently, this includes HTTPS server and offline previews. |
|
►
Sign in to add a comment |
|
Comment 1 by sophiechang@google.com
, Jan 2