[Autofill Sync] Dropdown Changes Tracking Bug |
|||
Issue descriptionThis is a tracking bug for changes to the Dropdown in support of upcoming changes to sync. See design doc (Googlers only) for more details: https://docs.google.com/document/d/18oV-_0QfoWM7rgp-suzDn4WspFNHRPKxI-4epHDQZIg/edit?usp=sharing
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9 commit 1950bc2cd26e3e992f02bd8060c209e68dfbbbd9 Author: Tommy Martino <tmartino@chromium.org> Date: Tue Nov 20 16:58:17 2018 [Autofill Sync] Adding new row type This CL introduces the frontend changes for an upcoming new row type in the Autofill dropdown footer. Specifically, it: * Adds a new frontend ID type. * Checks against this frontend ID to the child view creation loop. * Extracts the logic for choosing the layout type into a virtual method, replacing the anonymous helper and the optional override parameter used by the Footer rows to modify the layout type. * Uses this new method to set the layout type in this new row type. * Adds a frontend_id() convenience method to ItemView. For more details see (Googlers only): https://docs.google.com/document/d/18oV-_0QfoWM7rgp-suzDn4WspFNHRPKxI-4epHDQZIg/edit?usp=sharing Bug: 905052 Change-Id: I370b3dc86a4fd7abc7dffa606acd2bd68213c4ba Reviewed-on: https://chromium-review.googlesource.com/c/1334415 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609730} [modify] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/1950bc2cd26e3e992f02bd8060c209e68dfbbbd9/components/autofill/core/browser/popup_item_ids.h
,
Dec 5
,
Dec 12
,
Dec 18
Just checking: Is there anything left to do here for M72? Thanks!
,
Dec 18
Everything's done, though I found one missing accessibility event (crbug.com/915715). My guess would be that this is non-blocking; I can't prioritize a fix right now because I'm working on other, more severe accessibility bugs for non-Sync-Transport projects :) but hopefully I can slip a fix in for M73. |
|||
►
Sign in to add a comment |
|||
Comment 1 by feuunk@google.com
, Nov 20