Issue metadata
Sign in to add a comment
|
Remember password dialog is shown even though offer to save passwords is disabled
Reported by
j...@externl.com,
Nov 13
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3608.4 Safari/537.36 Steps to reproduce the problem: 1. Have "Offer to save passwords" disabled 2. Submit password to login to a website 3. "Offer to save passwords" pops up What is the expected behavior? It should not pop up What went wrong? Remember password dialog is shown even though offer to save passwords is disabled Did this work before? Yes Chrome version: 72.0.3608.4 Channel: dev OS Version: OS X 10.14.1 Flash Version:
,
Nov 14
Unable to reproduce the issue on chrome reported version# 72.0.3608.4 using Mac 10.14.1 with steps mentioned below: 1) Launched chrome reported version and disabled "Offer to save passwords in chrome://settings 2) Logged-in into fb.com with valid credentials, didn't observed any pop-up to save password @Reporter: Please find the attached screencast for your reference and provide your feedback on it, try to test this issue by creating new person with no apps and extensions in it and let us know if the issue still persists. Thanks!
,
Nov 14
++ Correction: checked the issue on Mac 10.14.0
,
Nov 14
I could not reproduce this on github either.
,
Nov 14
I was able to reproduce with a fresh profile. See attached.
,
Nov 14
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 14
Not sure if any way related, I did recently (for no real good reason) reset the chrome flags (chrome://flags) to the default settings. Lots of password flags in there, maybe a default is messed up?
,
Nov 14
Seems possibly related to the following settings. The issue went away after I disabled them. What's the default value supposed to be?
,
Nov 15
@joe: Thanks for feedback! Tested the issue on chrome reported version# 72.0.3608.4 using Mac 10.14.0 with steps mentioned in comment# 2. Also tried testing the issue by making the flags(#new-password-form-parsing, #new-password-form-parsing-for-saving) Default and Disabled. In both the cases, issue is not seen from our end. Hence CC'ing : dvadym to provide further inputs on this issue. Thanks!
,
Nov 15
Thank you, this was very good research. I can reproduce your problem on Linux with #new-password-form-parsing and #new-password-form-parsing-for-saving.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a commit 2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a Author: Vadym Doroshenko <dvadym@chromium.org> Date: Thu Nov 15 15:58:07 2018 Do not offer password saving when saving is disabled. This CL implements not saving of passwords in the new Password Manager architecture when Password Manager saving if off (i.e. "Offer to save passwords" settings is off). Bug: 905048 , 831123 Change-Id: Ic053f8ae9b28fc1e9d8d80ba5e1a469a4173fdec Reviewed-on: https://chromium-review.googlesource.com/c/1337344 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#608380} [modify] https://crrev.com/2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a/components/password_manager/core/browser/password_manager_unittest.cc
,
Nov 15
Issue 905638 has been merged into this issue.
,
Nov 16
As per comment# 11, Fix is already landed, hence removing Needs-Bisect label to this issue. Thanks!
,
Nov 19
,
Nov 29
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by swarnasree.mukkala@chromium.org
, Nov 14