New issue
Advanced search Search tips

Issue 905048 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 831123



Sign in to add a comment

Remember password dialog is shown even though offer to save passwords is disabled

Reported by j...@externl.com, Nov 13

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3608.4 Safari/537.36

Steps to reproduce the problem:
1. Have "Offer to save passwords" disabled
2. Submit password to login to a website
3. "Offer to save passwords" pops up

What is the expected behavior?
It should not pop up

What went wrong?
Remember password dialog is shown even though offer to save passwords is disabled

Did this work before? Yes 

Chrome version: 72.0.3608.4  Channel: dev
OS Version: OS X 10.14.1
Flash Version:
 
Screen Shot 2018-11-13 at 5.18.42 PM.png
1.1 MB View Download
Labels: Needs-Triage-M72 Needs-Bisect
Cc: viswa.karala@chromium.org
Components: -UI UI>Browser>Passwords
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on chrome reported version# 72.0.3608.4 using Mac 10.14.1 with steps mentioned below:
1) Launched chrome reported version and disabled "Offer to save passwords in chrome://settings
2) Logged-in into fb.com with valid credentials, didn't observed any pop-up to save password

@Reporter: Please find the attached screencast for your reference and provide your feedback on it, try to test this issue by creating new person with no apps and extensions in it and let us know if the issue still persists.

Thanks!
905048.mp4
2.0 MB View Download
++ Correction: checked the issue on Mac 10.14.0
I could not reproduce this on github either.
I was able to reproduce with a fresh profile. See attached.
Screen Recording 2018-11-14 at 9.25.44 AM.mov
5.9 MB View Download
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 14

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Not sure if any way related, I did recently (for no real good reason) reset the chrome flags (chrome://flags) to the default settings. Lots of password flags in there, maybe a default is messed up?
Seems possibly related to the following settings. The issue went away after I disabled them. What's the default value supposed to be?
Screen Shot 2018-11-14 at 10.06.54 AM.png
128 KB View Download
Cc: dvadym@chromium.org
@joe: Thanks for feedback!

Tested the issue on chrome reported version# 72.0.3608.4 using Mac 10.14.0 with steps mentioned in comment# 2. Also tried testing the issue by making the flags(#new-password-form-parsing, #new-password-form-parsing-for-saving) Default and Disabled. In both the cases, issue is not seen from our end. Hence CC'ing : dvadym to provide further inputs on this issue.

Thanks!
Blocking: 831123
Cc: -dvadym@chromium.org
Labels: -Pri-2 Pri-1
Owner: dvadym@chromium.org
Status: Assigned (was: Unconfirmed)
Thank you, this was very good research. I can reproduce your problem on Linux with #new-password-form-parsing and #new-password-form-parsing-for-saving.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a

commit 2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Thu Nov 15 15:58:07 2018

Do not offer password saving when saving is disabled.

This CL implements not saving of passwords in the new Password Manager
architecture when Password Manager saving if off (i.e.
"Offer to save passwords" settings is off).

Bug:  905048 , 831123

Change-Id: Ic053f8ae9b28fc1e9d8d80ba5e1a469a4173fdec
Reviewed-on: https://chromium-review.googlesource.com/c/1337344
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608380}
[modify] https://crrev.com/2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a/components/password_manager/core/browser/password_manager_unittest.cc

Cc: a...@chromium.org vabr@chromium.org vasi...@chromium.org dvadym@chromium.org
 Issue 905638  has been merged into this issue.
Labels: -Needs-Bisect
As per comment# 11, Fix is already landed, hence removing Needs-Bisect label to this issue.

Thanks!
Status: Fixed (was: Assigned)
Cc: -vabr@chromium.org

Sign in to add a comment