[Merge Request M71] Reset migration acceptance bit after a migration |
|||||
Issue descriptionRequesting to merge the CL resetting migration user acceptance bit after sending one request. https://chromium-review.googlesource.com/c/chromium/src/+/1333122 This CL changes the reset to a correct place. So the next RiskData call would not trigger migration. Have tested successfully in Chromium implementation. Confirm no other project is touching this file now. Thanks!
,
Nov 13
Approving merge to M71 branch 3578 based on comment #0 and per offline chat with siyua@.
,
Nov 13
Merged into 3578 via https://chromium-review.googlesource.com/c/chromium/src/+/1334560.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc96d12c9edb04a7451c9b75644a06f2758595b3 commit cc96d12c9edb04a7451c9b75644a06f2758595b3 Author: siyua <siyua@chromium.org> Date: Tue Nov 13 22:24:55 2018 [AF Paradise] Reset migration acceptance bit after a migration If one migration request is finished and the user submits another migration request in the same tab, the card would be automatically saved. Reason: The member variable user_accepted_main_migration_dialog_ is not correctly reset to false after a request is sent. So when next time the risk data is loaded, a request would be direcly sent to server. This is a bug for M71 code. Need to merge asap. Bug: 905041 Change-Id: Ia77cdddc6d80550e0e23ff327f07a5c7279ba15f Reviewed-on: https://chromium-review.googlesource.com/c/1333122 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607746}(cherry picked from commit b834898709772ff1af9b3d4ed79791fb683e2245) Reviewed-on: https://chromium-review.googlesource.com/c/1334560 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#668} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/cc96d12c9edb04a7451c9b75644a06f2758595b3/components/autofill/core/browser/local_card_migration_manager.cc
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc96d12c9edb04a7451c9b75644a06f2758595b3 Commit: cc96d12c9edb04a7451c9b75644a06f2758595b3 Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-11-13 22:24:55 +0000 UTC [AF Paradise] Reset migration acceptance bit after a migration If one migration request is finished and the user submits another migration request in the same tab, the card would be automatically saved. Reason: The member variable user_accepted_main_migration_dialog_ is not correctly reset to false after a request is sent. So when next time the risk data is loaded, a request would be direcly sent to server. This is a bug for M71 code. Need to merge asap. Bug: 905041 Change-Id: Ia77cdddc6d80550e0e23ff327f07a5c7279ba15f Reviewed-on: https://chromium-review.googlesource.com/c/1333122 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607746}(cherry picked from commit b834898709772ff1af9b3d4ed79791fb683e2245) Reviewed-on: https://chromium-review.googlesource.com/c/1334560 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#668} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sheriffbot@chromium.org
, Nov 13