New issue
Advanced search Search tips

Issue 905041 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request M71] Reset migration acceptance bit after a migration

Project Member Reported by siyua@chromium.org, Nov 13

Issue description

Requesting to merge the CL resetting migration user acceptance bit after sending one request.

https://chromium-review.googlesource.com/c/chromium/src/+/1333122

This CL changes the reset to a correct place. So the next RiskData call would not
trigger migration.

Have tested successfully in Chromium implementation. Confirm no other project is touching this file now.

Thanks!

 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 13

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #0 and per offline chat with siyua@. 
Status: Fixed (was: Assigned)
Merged into 3578 via https://chromium-review.googlesource.com/c/chromium/src/+/1334560.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc96d12c9edb04a7451c9b75644a06f2758595b3

commit cc96d12c9edb04a7451c9b75644a06f2758595b3
Author: siyua <siyua@chromium.org>
Date: Tue Nov 13 22:24:55 2018

[AF Paradise] Reset migration acceptance bit after a migration

If one migration request is finished and the user submits another
migration request in the same tab, the card would be automatically saved.

Reason: The member variable user_accepted_main_migration_dialog_ is not
correctly reset to false after a request is sent. So when next time the
risk data is loaded, a request would be direcly sent to server.

This is a bug for M71 code. Need to merge asap.

Bug:  905041 
Change-Id: Ia77cdddc6d80550e0e23ff327f07a5c7279ba15f
Reviewed-on: https://chromium-review.googlesource.com/c/1333122
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607746}(cherry picked from commit b834898709772ff1af9b3d4ed79791fb683e2245)
Reviewed-on: https://chromium-review.googlesource.com/c/1334560
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3578@{#668}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/cc96d12c9edb04a7451c9b75644a06f2758595b3/components/autofill/core/browser/local_card_migration_manager.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/cc96d12c9edb04a7451c9b75644a06f2758595b3

Commit: cc96d12c9edb04a7451c9b75644a06f2758595b3
Author: siyua@chromium.org
Commiter: jsaul@google.com
Date: 2018-11-13 22:24:55 +0000 UTC

[AF Paradise] Reset migration acceptance bit after a migration

If one migration request is finished and the user submits another
migration request in the same tab, the card would be automatically saved.

Reason: The member variable user_accepted_main_migration_dialog_ is not
correctly reset to false after a request is sent. So when next time the
risk data is loaded, a request would be direcly sent to server.

This is a bug for M71 code. Need to merge asap.

Bug:  905041 
Change-Id: Ia77cdddc6d80550e0e23ff327f07a5c7279ba15f
Reviewed-on: https://chromium-review.googlesource.com/c/1333122
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607746}(cherry picked from commit b834898709772ff1af9b3d4ed79791fb683e2245)
Reviewed-on: https://chromium-review.googlesource.com/c/1334560
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3578@{#668}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment