New issue
Advanced search Search tips

Issue 905024 link

Starred by 2 users
Status: Fixed
Owner:
lethalantidote@chromium.org
Closed: Nov 30
Cc:
jazzhsu@chromium.org
steimel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Media Controls Accessibility: Volume slider should read "56%" instead of "0.56"

Project Member Reported by steimel@chromium.org, Nov 13 
From accessibility review on crbug.com/888554, we want screen readers to get a more user-friendly verbalization from the volume slider. Currently, the slider reads as a decimal value between 0 and 1. Instead, we want the value to be verbalized as a percentage.

Comment 1 by lethalantidote@chromium.org, Nov 17

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf0717195ed5798c1970f4897682a1517c229e75

commit cf0717195ed5798c1970f4897682a1517c229e75
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Nov 29 12:16:55 2018

[Accessibility] Volume slider reads out level in percentages.

This CL makes it such that the volume level is read out as a percentage
in aria. This CL also amplifies how the accessibility information is
given to aria, by setting attributes instead of explicitly creating
accessibility nodes.

Bug:  905024 
Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00
Reviewed-on: https://chromium-review.googlesource.com/c/1337298
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612160}
[modify] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[add] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/content/test/data/accessibility/html/video-controls-expected-blink.txt
[add] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/content/test/data/accessibility/html/video-controls.html
[add] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/cf0717195ed5798c1970f4897682a1517c229e75/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/769b90879117a57d8b8805e9b4205e3fe068d86a

commit 769b90879117a57d8b8805e9b4205e3fe068d86a
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Nov 29 14:27:10 2018

Revert "[Accessibility] Volume slider reads out level in percentages."

This reverts commit cf0717195ed5798c1970f4897682a1517c229e75.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 612160 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2YwNzE3MTk1ZWQ1Nzk4YzE5NzBmNDg5NzY4MmExNTE3YzIyOWU3NQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/5253

Sample Failed Step: network_service_content_browsertests on Ubuntu-16.04

Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls

Original change's description:
> [Accessibility] Volume slider reads out level in percentages.
> 
> This CL makes it such that the volume level is read out as a percentage
> in aria. This CL also amplifies how the accessibility information is
> given to aria, by setting attributes instead of explicitly creating
> accessibility nodes.
> 
> Bug:  905024 
> Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> Reviewed-on: https://chromium-review.googlesource.com/c/1337298
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612160}

Change-Id: I06f47bd929725e2176c9cc9a48e20993d1cb78f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  905024 ,  910123 
Reviewed-on: https://chromium-review.googlesource.com/c/1354196
Cr-Commit-Position: refs/heads/master@{#612184}
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/content/test/data/accessibility/html/video-controls-expected-blink.txt
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/content/test/data/accessibility/html/video-controls.html
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faf5cdcc8d2d8900033692fa863403a16e9090c9

commit faf5cdcc8d2d8900033692fa863403a16e9090c9
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri Nov 30 00:25:26 2018

Reland "[Accessibility] Volume slider reads out level in percentages."

This is a reland of cf0717195ed5798c1970f4897682a1517c229e75

Original change's description:
> [Accessibility] Volume slider reads out level in percentages.
>
> This CL makes it such that the volume level is read out as a percentage
> in aria. This CL also amplifies how the accessibility information is
> given to aria, by setting attributes instead of explicitly creating
> accessibility nodes.
>
> Bug:  905024 
> Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> Reviewed-on: https://chromium-review.googlesource.com/c/1337298
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612160}

TBR=mlamouri@chromium.org, dmazzoni@chromium.org, thakis@chromium.org

Bug:  905024 
Change-Id: Ie35c05c274dfd36f3e9ec0a32b587a98a62249d9
Reviewed-on: https://chromium-review.googlesource.com/c/1356007
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612469}
[modify] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[add] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/content/test/data/accessibility/html/video-controls-expected-blink.txt
[add] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/content/test/data/accessibility/html/video-controls.html
[add] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/faf5cdcc8d2d8900033692fa863403a16e9090c9/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc

Comment 5 by lethalantidote@google.com, Nov 30

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4a238458d4031971ef7d00923e6ab43781eaa8

commit da4a238458d4031971ef7d00923e6ab43781eaa8
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Nov 30 01:51:47 2018

Revert "Reland "[Accessibility] Volume slider reads out level in percentages.""

This reverts commit faf5cdcc8d2d8900033692fa863403a16e9090c9.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 612469 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmFmNWNkY2M4ZDJkODkwMDAzMzY5MmZhODYzNDAzYTE2ZTkwOTBjOQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/16665

Sample Failed Step: single_process_mash_content_browsertests

Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls

Original change's description:
> Reland "[Accessibility] Volume slider reads out level in percentages."
> 
> This is a reland of cf0717195ed5798c1970f4897682a1517c229e75
> 
> Original change's description:
> > [Accessibility] Volume slider reads out level in percentages.
> >
> > This CL makes it such that the volume level is read out as a percentage
> > in aria. This CL also amplifies how the accessibility information is
> > given to aria, by setting attributes instead of explicitly creating
> > accessibility nodes.
> >
> > Bug:  905024 
> > Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337298
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612160}
> 
> TBR=mlamouri@chromium.org, dmazzoni@chromium.org, thakis@chromium.org
> 
> Bug:  905024 
> Change-Id: Ie35c05c274dfd36f3e9ec0a32b587a98a62249d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1356007
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612469}

Change-Id: Icc1f84da3c66189f0d3b30108e0ab4330d4061f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  905024 ,  910442 
Reviewed-on: https://chromium-review.googlesource.com/c/1356137
Cr-Commit-Position: refs/heads/master@{#612501}
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/content/test/data/accessibility/html/video-controls-expected-blink.txt
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/content/test/data/accessibility/html/video-controls.html
[delete] https://crrev.com/6074b2240555b1cd1936ddfa9fcbb51e7b8f59e6/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/da4a238458d4031971ef7d00923e6ab43781eaa8/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc

Comment 7 by ram...@google.com, Dec 5 

Verified fix on chrome dev 72.0.3627.7
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd

commit d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Tue Dec 18 01:54:02 2018

Reland: [Accessibility] Volume slider reads out level in percentages.

This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00

This CL makes it such that the volume level is read out as a percentage
in aria. This CL also amplifies how the accessibility information is
given to aria, by setting attributes instead of explicitly creating
accessibility nodes.

TBR=thakis@chromium.org

Bug:  905024 
Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043
Reviewed-on: https://chromium-review.googlesource.com/c/1373032
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617338}
[modify] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[add] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/content/test/data/accessibility/html/video-controls-expected-blink.txt
[add] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/content/test/data/accessibility/html/video-controls.html
[modify] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
[add] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22ccebfe9229626c14dec05eceebf322d83185a4

commit 22ccebfe9229626c14dec05eceebf322d83185a4
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Dec 18 03:35:08 2018

Revert "Reland: [Accessibility] Volume slider reads out level in percentages."

This reverts commit d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 617338 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDAxOGMwNzZlODVkNzVkOGE3MmVmNGE3ZjhhZGY1M2JlZGI0YjBiZAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/17415

Sample Failed Step: single_process_mash_content_browsertests

Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls

Original change's description:
> Reland: [Accessibility] Volume slider reads out level in percentages.
> 
> This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> 
> This CL makes it such that the volume level is read out as a percentage
> in aria. This CL also amplifies how the accessibility information is
> given to aria, by setting attributes instead of explicitly creating
> accessibility nodes.
> 
> TBR=thakis@chromium.org
> 
> Bug:  905024 
> Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043
> Reviewed-on: https://chromium-review.googlesource.com/c/1373032
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617338}

Change-Id: I18c48f0c2f1c732e6be8b74690360382f6c7f3d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  905024 , 916003
Reviewed-on: https://chromium-review.googlesource.com/c/1381725
Cr-Commit-Position: refs/heads/master@{#617365}
[modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/content/test/data/accessibility/html/video-controls-expected-blink.txt
[delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/content/test/data/accessibility/html/video-controls.html
[modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
[delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543a2def162aeb06e9709ed4b8e4f074d9d8c18e

commit 543a2def162aeb06e9709ed4b8e4f074d9d8c18e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Dec 26 18:15:47 2018

Reland "Reland: [Accessibility] Volume slider reads out level in percentages."

This is a reland of d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd

Original change's description:
> Reland: [Accessibility] Volume slider reads out level in percentages.
>
> This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00
>
> This CL makes it such that the volume level is read out as a percentage
> in aria. This CL also amplifies how the accessibility information is
> given to aria, by setting attributes instead of explicitly creating
> accessibility nodes.
>
> TBR=thakis@chromium.org
>
> Bug:  905024 
> Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043
> Reviewed-on: https://chromium-review.googlesource.com/c/1373032
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617338}

TBR=thakis@chromium.org,dmazzoni@chromium.org,mlamouri@chromium.org

Bug:  905024 
Change-Id: Ie308a4b30032491333072681fcf214a9fab58d5c
Reviewed-on: https://chromium-review.googlesource.com/c/1383307
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618940}
[modify] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[add] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/content/test/data/accessibility/html/video-controls-expected-blink.txt
[add] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/content/test/data/accessibility/html/video-controls.html
[add] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b

commit 70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Dec 26 21:36:48 2018

Revert "Reland "Reland: [Accessibility] Volume slider reads out level in percentages.""

This reverts commit 543a2def162aeb06e9709ed4b8e4f074d9d8c18e.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 618940 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTQzYTJkZWYxNjJhZWIwNmU5NzA5ZWQ0YjhlNGYwNzRkOWQ4YzE4ZQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/5873

Sample Failed Step: network_service_content_browsertests on Ubuntu-16.04

Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls

Original change's description:
> Reland "Reland: [Accessibility] Volume slider reads out level in percentages."
> 
> This is a reland of d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd
> 
> Original change's description:
> > Reland: [Accessibility] Volume slider reads out level in percentages.
> >
> > This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> >
> > This CL makes it such that the volume level is read out as a percentage
> > in aria. This CL also amplifies how the accessibility information is
> > given to aria, by setting attributes instead of explicitly creating
> > accessibility nodes.
> >
> > TBR=thakis@chromium.org
> >
> > Bug:  905024 
> > Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043
> > Reviewed-on: https://chromium-review.googlesource.com/c/1373032
> > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#617338}
> 
> TBR=thakis@chromium.org,dmazzoni@chromium.org,mlamouri@chromium.org
> 
> Bug:  905024 
> Change-Id: Ie308a4b30032491333072681fcf214a9fab58d5c
> Reviewed-on: https://chromium-review.googlesource.com/c/1383307
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618940}

Change-Id: I3dca4908cc62c213585bc99eefe73f114bd55fe9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  905024 , 916003
Reviewed-on: https://chromium-review.googlesource.com/c/1391326
Cr-Commit-Position: refs/heads/master@{#618963}
[modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/content/test/data/accessibility/html/video-controls-expected-blink.txt
[delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/content/test/data/accessibility/html/video-controls.html
[delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d56d9dbefade57d99ff97351bdb33ebd9535406d

commit d56d9dbefade57d99ff97351bdb33ebd9535406d
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Jan 02 22:14:58 2019

Reland "Reland "Reland: [Accessibility] Volume slider reads out level in percentages.""

This is a reland of 543a2def162aeb06e9709ed4b8e4f074d9d8c18e

Original change's description:
> Reland "Reland: [Accessibility] Volume slider reads out level in percentages."
>
> This is a reland of d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd
>
> Original change's description:
> > Reland: [Accessibility] Volume slider reads out level in percentages.
> >
> > This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> >
> > This CL makes it such that the volume level is read out as a percentage
> > in aria. This CL also amplifies how the accessibility information is
> > given to aria, by setting attributes instead of explicitly creating
> > accessibility nodes.
> >
> > TBR=thakis@chromium.org
> >
> > Bug:  905024 
> > Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043
> > Reviewed-on: https://chromium-review.googlesource.com/c/1373032
> > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#617338}
>
> TBR=thakis@chromium.org,dmazzoni@chromium.org,mlamouri@chromium.org
>
> Bug:  905024 
> Change-Id: Ie308a4b30032491333072681fcf214a9fab58d5c
> Reviewed-on: https://chromium-review.googlesource.com/c/1383307
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618940}

TBR=thakis@chromium.org,dmazzoni@chromium.org,mlamouri@chromium.org

Bug:  905024 
Change-Id: I8e4737b5ddea923f9ccef9ea5ec65485f5f63f66
Reviewed-on: https://chromium-review.googlesource.com/c/1391296
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619513}
[modify] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[add] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/content/test/data/accessibility/html/video-controls-expected-blink.txt
[add] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/content/test/data/accessibility/html/video-controls.html
[add] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/d56d9dbefade57d99ff97351bdb33ebd9535406d/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
►

Sign in to add a comment