New issue
Advanced search Search tips

Issue 905017 link

Starred by 2 users

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

catapult: Unable to run benchmark on desktop when an android device is connected

Project Member Reported by sadrul@chromium.org, Nov 13

Issue description

I have a local linux build of chrome, and also an android device connected over USB (a non-rooted device, for running unit-tests etc). When I try to run a benchmark (e.g. rendering.desktop), it attempts to run on the android device, and fails.

The command I use to run the test:

  tools/perf/run_benchmark run rendering.desktop --browser=exact --browser-executable=./out/lin/chrome \
      --pageset-repeat=1 --story-filter=yahoo_news_2018

The failure:

(CRITICAL) 2018-11-13 11:31:31,182 timeout_retry.Run:173  (TimeoutThread-1-for-MainThread) Exception on EnableRoot(0715f741e0d40d38, retries=3, timeout=30), attempt 1 of 4: CommandFailedErr
or('(device: 0715f741e0d40d38) Unable to root device with user build.',)   
(CRITICAL) 2018-11-13 11:31:31,284 timeout_retry.Run:173  (TimeoutThread-2-for-MainThread) Exception on EnableRoot(0715f741e0d40d38, retries=3, timeout=30), attempt 2 of 4: CommandFailedError('(device: 0715f741e0d40d38) Unable to root device with user build.',)
(CRITICAL) 2018-11-13 11:31:31,385 timeout_retry.Run:173  (TimeoutThread-3-for-MainThread) Exception on EnableRoot(0715f741e0d40d38, retries=3, timeout=30), attempt 3 of 4: CommandFailedError('(device: 0715f741e0d40d38) Unable to root device with user build.',)
(WARNING) 2018-11-13 11:31:31,486 android_platform_backend.__init__:78  Unable to root 0715f741e0d40d38
(CRITICAL) 2018-11-13 11:31:31,855 timeout_retry.Run:173  (TimeoutThread-1-for-MainThread) Exception on RunShellCommand(0715f741e0d40d38, su 0 ls /root && ! ls /root, check_return=True, shell=True, timeout=30, retries=3), attempt 1 of 4: AdbShellCommandFailedError('(device: 0715f741e0d40d38) shell command run via adb failed on the device:\n  command: su 0 ls /root && ! ls /root\n  exit status: 127\n  output:\n  - /system/bin/sh: su: not found\n',)
(CRITICAL) 2018-11-13 11:31:31,989 timeout_retry.Run:173  (TimeoutThread-2-for-MainThread) Exception on RunShellCommand(0715f741e0d40d38, su 0 ls /root && ! ls /root, check_return=True, shell=True, timeout=30, retries=3), attempt 2 of 4: AdbShellCommandFailedError('(device: 0715f741e0d40d38) shell command run via adb failed on the device:\n  command: su 0 ls /root && ! ls /root\n  exit status: 127\n  output:\n  - /system/bin/sh: su: not found\n',)
(CRITICAL) 2018-11-13 11:31:32,154 timeout_retry.Run:173  (TimeoutThread-3-for-MainThread) Exception on RunShellCommand(0715f741e0d40d38, su 0 ls /root && ! ls /root, check_return=True, shell=True, timeout=30, retries=3), attempt 3 of 4: AdbShellCommandFailedError('(device: 0715f741e0d40d38) shell command run via adb failed on the device:\n  command: su 0 ls /root && ! ls /root\n  exit status: 127\n  output:\n  - /system/bin/sh: su: not found\n',)
(ERROR) 2018-11-13 11:31:32,319 platform.GetPlatformForDevice:69  Fail to create platform instance for Android device 0715f741e0d40d38.

Traceback (most recent call last):
  <module> at /usr/local/google/home/sadrul/devel/c/src/tools/perf/run_benchmark:27
    sys.exit(main())
  main at /usr/local/google/home/sadrul/devel/c/src/tools/perf/run_benchmark:23
    return benchmark_runner.main(config, [trybot_command.Trybot])
  main at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:446
    return command_instance.Run(options)
  Run at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:316
    return min(255, b.Run(args))
  Run at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/benchmark.py:105
    return story_runner.RunBenchmark(self, finder_options)
  RunBenchmark at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:314
    benchmark.CustomizeBrowserOptions(finder_options.browser_options)
  CustomizeBrowserOptions at /usr/local/google/home/sadrul/devel/c/src/tools/perf/core/perf_benchmark.py:96
    variations = self._GetVariationsBrowserArgs(options.finder_options)
  _GetVariationsBrowserArgs at /usr/local/google/home/sadrul/devel/c/src/tools/perf/core/perf_benchmark.py:141
    possible_browser = browser_finder.FindBrowser(finder_options)
  Cacher at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/decorators.py:35
    cacher.__cache[key] = obj(*args, **kwargs)
  FindBrowser at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_finder.py:69
    curr_browsers = finder.FindAllAvailableBrowsers(options, device)
  FindAllAvailableBrowsers at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py:399
    android_platform = platform.GetPlatformForDevice(device, finder_options)
  GetPlatformForDevice at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/core/platform.py:64
    finder_options))
  CreatePlatformForDevice at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py:115
    platform_backend = AndroidPlatformBackend(device)
  __init__ at /usr/local/google/home/sadrul/devel/c/src/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py:82
    'Android device must have root access to run Telemetry')
AssertionError: Android device must have root access to run Telemetry


I think catapult should not look for external browsers/devices when --browser=exact is used.
 
Cc: -nednguyen@chromium.org nedngu...@google.com crouleau@chromium.org

Comment 2 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 3 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment