New issue
Advanced search Search tips

Issue 905013 link

Starred by 2 users
Status: Verified
Owner:
mrobin...@igalia.com
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[Orca] Cannot ascend accessibility tree beyond document

Project Member Reported by joanmari...@gmail.com, Nov 13 
Steps to reproduce:
1. Launch Chromium and view any web page
2. Launch Accerciser and locate (highlight) the current web page*
3. In Accerciser's iPython console type: acc.parent

*Be sure to examine the page's children. There seem to be two objects with the role "document web," only one of which contains the actual content of the page being viewed. (The other object has only a single child with role of "redundant object".)

Expected results: A parent object would be returned (at the present time this object has the role of "redundant object".

Actual results: Null is returned.

Impact: Orca sometimes needs to ascend the accessibility tree to find the current window and determine if it is the active window. This logic can impact whether or not an object is presented. The broken accessibility tree hinders this work.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10e59df1021224b9bdcd05cecd8461db4598ed61

commit 10e59df1021224b9bdcd05cecd8461db4598ed61
Author: Martin Robinson <mrobinson@igalia.com>
Date: Fri Jan 11 17:12:07 2019

Allow access to document accessible parent on AuraLinux

Previously a null was returned when querying the parent accessible of a
document on AuraLinux. This change implements sets this accessible as a
property on the view that contains the WebContents, allowing native
accessibility APIs to traverse all the way up the accessibility
tree by querying this value.


Bug:  905013 
Change-Id: I960becdcbc99a035aae00ff9f550206b042b5af3
Reviewed-on: https://chromium-review.googlesource.com/c/1356596
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622038}
[add] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/content/browser/accessibility/accessibility_auralinux_browsertest.cc
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/content/test/BUILD.gn
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/aura/client/aura_constants.h
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/gfx/native_widget_types.h
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/native/native_view_host.cc
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/native/native_view_host.h
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/native/native_view_host_aura.cc
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/native/native_view_host_aura.h
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/native/native_view_host_mac.h
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/native/native_view_host_mac.mm
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/native/native_view_host_wrapper.h
[modify] https://crrev.com/10e59df1021224b9bdcd05cecd8461db4598ed61/ui/views/controls/webview/webview.cc

Comment 2 by mrobin...@igalia.com, Jan 11

Owner: joanmari...@gmail.com
Status: Fixed (was: Untriaged)

Comment 3 by joanmari...@gmail.com, Jan 14

Status: Verified (was: Fixed)
Verifying. Another hack removed from Orca. Thanks!!

Comment 4 by mrobin...@igalia.com, Jan 15

Owner: mrobin...@igalia.com
Status: Assigned (was: Verified)
Thanks for the verification. I'm going to re-open this to track some of the related fixes and cleanups as well. This seems like a good place to collect everything.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/857b9b8f7b4845bb5bc2c732f2bc6c0a37b4cf41

commit 857b9b8f7b4845bb5bc2c732f2bc6c0a37b4cf41
Author: Martin Robinson <mrobinson@igalia.com>
Date: Thu Jan 17 09:33:27 2019

Remove BrowserAccessibilityManagerAuraLinux::parent_object_

This member is not used and the parent is now accessed via a window
property.

Bug:  905013 
Change-Id: I52e4372f8849f2c9111233ed1c12f29ec8525845
Reviewed-on: https://chromium-review.googlesource.com/c/1415252
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623622}
[modify] https://crrev.com/857b9b8f7b4845bb5bc2c732f2bc6c0a37b4cf41/content/browser/accessibility/browser_accessibility_manager_auralinux.cc
[modify] https://crrev.com/857b9b8f7b4845bb5bc2c732f2bc6c0a37b4cf41/content/browser/accessibility/browser_accessibility_manager_auralinux.h

Comment 6 by mrobin...@igalia.com, Jan 17 (5 days ago)

Status: Verified (was: Assigned)
►

Sign in to add a comment