[iOS] Rename SnapshotGeneratorDelegate selector names. |
|||
Issue descriptionIn order to prevent these callbacks from being used in non-delegated calls, these should be renamed to follow the ObjC delegate naming conventions where the SnapshotGenerator object is passed as the first parameter to the selectors. As part of this work, ensure that SnapshotGeneratorDelegate methods are not used by anything other than SnapshotGenerator.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14dcb3e2562d003ecbb15ad1c014673e9b4731bb commit 14dcb3e2562d003ecbb15ad1c014673e9b4731bb Author: edchin <edchin@chromium.org> Date: Wed Nov 28 20:21:43 2018 [ios] Update SnapshotGeneratorDelegate This CL renames SnapshotGeneratorDelegate protocol methods to be unique to SnapshotGenerator. Bug: 904992 Change-Id: I6357931f782a7d533a74a0b438751b4d5a78aab4 Reviewed-on: https://chromium-review.googlesource.com/c/1345128 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611847} [modify] https://crrev.com/14dcb3e2562d003ecbb15ad1c014673e9b4731bb/ios/chrome/browser/snapshots/fake_snapshot_generator_delegate.mm [modify] https://crrev.com/14dcb3e2562d003ecbb15ad1c014673e9b4731bb/ios/chrome/browser/snapshots/snapshot_generator.mm [modify] https://crrev.com/14dcb3e2562d003ecbb15ad1c014673e9b4731bb/ios/chrome/browser/snapshots/snapshot_generator_delegate.h [modify] https://crrev.com/14dcb3e2562d003ecbb15ad1c014673e9b4731bb/ios/chrome/browser/snapshots/snapshot_tab_helper_unittest.mm [modify] https://crrev.com/14dcb3e2562d003ecbb15ad1c014673e9b4731bb/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/14dcb3e2562d003ecbb15ad1c014673e9b4731bb/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
,
Nov 28
,
Jan 1
|
|||
►
Sign in to add a comment |
|||
Comment 1 by edchin@chromium.org
, Nov 28