New issue
Advanced search Search tips

Issue 904985 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request M71] Update text strings in migration bubble and dialog

Project Member Reported by siyua@chromium.org, Nov 13

Issue description

Requesting to merge CL updating the text in migration bubble and dialog.

https://chromium-review.googlesource.com/c/chromium/src/+/1330756

This is some simple string changes. Attached implementation screenshots.



 
Screenshot from 2018-11-09 15-23-41.png
63.9 KB View Download
Screenshot from 2018-11-09 15-24-32.png
95.3 KB View Download
Screenshot from 2018-11-09 15-25-22.png
102 KB View Download
Labels: -Merge-Request-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on internal mail thread. Pls merge ASAP. Thank you.
Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d5caa68658ec98780d15dfcfd7ec8d699dcb6ee2

Commit: d5caa68658ec98780d15dfcfd7ec8d699dcb6ee2
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-11-13 21:45:19 +0000 UTC

[Merge-71] Update text strings in migration bubble and dialog

Uploaded screenshots in the bug (comment#16)

TBR=siyua@chromium.org

(cherry picked from commit 023f50ddccf1b9b5c3d63ec3bd713548c828d73b)

Bug: 897998,  904985 
Change-Id: I83aaf75efaf49ed2adda3a4773aacdc10caedb32
Reviewed-on: https://chromium-review.googlesource.com/c/1330756
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607389}
Reviewed-on: https://chromium-review.googlesource.com/c/1334407
Cr-Commit-Position: refs/branch-heads/3578@{#666}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 13

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5caa68658ec98780d15dfcfd7ec8d699dcb6ee2

commit d5caa68658ec98780d15dfcfd7ec8d699dcb6ee2
Author: sebsg <sebsg@chromium.org>
Date: Tue Nov 13 21:45:19 2018

[Merge-71] Update text strings in migration bubble and dialog

Uploaded screenshots in the bug (comment#16)

TBR=siyua@chromium.org

(cherry picked from commit 023f50ddccf1b9b5c3d63ec3bd713548c828d73b)

Bug: 897998,  904985 
Change-Id: I83aaf75efaf49ed2adda3a4773aacdc10caedb32
Reviewed-on: https://chromium-review.googlesource.com/c/1330756
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607389}
Reviewed-on: https://chromium-review.googlesource.com/c/1334407
Cr-Commit-Position: refs/branch-heads/3578@{#666}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/d5caa68658ec98780d15dfcfd7ec8d699dcb6ee2/components/autofill_strings.grdp

Status: Fixed (was: Assigned)
Labels: TE-NeedsTriageFromHYD
Tried testing this issue on Windows 10 on the build without fix 71.0.3545.0 and on the latest M-71 71.0.3578.53 build by following the below steps.

1. Launched Chrome and signed into Chrome.
2. As per the screen shots provided in issue 897998-comment #16, we need to add GPay app.
3. Tried installing GPay app by clicking on Google Apps icon -> searched for GPay and on clicking Install button, the app is getting installed on a mobile device.
Attached is the screen cast for reference.

Note: Also unable to access the links provided in comment #0 of issue 897998, as it needs corp account to login.

Hence adding 'TE-NeedsTriageFromHYD' and request Inhouse team to check and confirm the fix on the latest M-72 build.

Thanks..
904985.mp4
4.0 MB View Download
Hi susan.boorgula@, are you by any chance replying to a wrong thread? As the test in the video is unrelated to this bug at all.
Labels: -TE-NeedsTriageFromHYD

Sign in to add a comment