When it's enabled, a failed token enrollment blocks Chrome launch process. it's disabled by default
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51910fbb78488df9877b82fe8c79a22875fac215 commit 51910fbb78488df9877b82fe8c79a22875fac215 Author: Owen Min <zmin@chromium.org> Date: Wed Nov 14 20:47:02 2018 Add an error option in BrowserDMTokenStorage The error option determines whether we show the error dialog when the token enrollment is failed. Bug: 904983 Change-Id: If43e4a3fdc71501ceb1feae16da0f87b88e84828 Reviewed-on: https://chromium-review.googlesource.com/c/1334408 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Georges Khalil <georgesak@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#608116} [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage.cc [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage.h [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage_linux.cc [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage_linux.h [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage_mac.h [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage_mac.mm [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage_unittest.cc [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage_win.cc [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/browser_dm_token_storage_win.h [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc [modify] https://crrev.com/51910fbb78488df9877b82fe8c79a22875fac215/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3 commit fe25b3e2c531dc7e82383a9dc97477ba5f504dc3 Author: Owen Min <zmin@chromium.org> Date: Mon Nov 19 17:28:10 2018 Do not display error message when token enrollment failed if admin choose to do so Bug: 904983 Change-Id: I204ff2ba026c4f0b5f24cadc0382051f53d09e14 Reviewed-on: https://chromium-review.googlesource.com/c/1336002 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609343} [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/chrome/browser/policy/machine_level_user_cloud_policy_controller.cc [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/chrome/browser/policy/machine_level_user_cloud_policy_controller.h [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher.cc [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher.h [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher_unittest.cc [modify] https://crrev.com/fe25b3e2c531dc7e82383a9dc97477ba5f504dc3/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a129a005d6db99d797613f8ec05f1bd7f1f9888 commit 4a129a005d6db99d797613f8ec05f1bd7f1f9888 Author: Owen Min <zmin@chromium.org> Date: Wed Nov 21 23:03:36 2018 Load cloud management enrollment option on Windows. The option is read from the Registry with the same key as the enrollment token. The value is CloudManagementBlockOnFailureEnabled. Bug: 904983 Change-Id: Ia8bada4e79d236fb9f85320e38ed6588f34a5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1345211 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610251} [modify] https://crrev.com/4a129a005d6db99d797613f8ec05f1bd7f1f9888/chrome/browser/policy/browser_dm_token_storage_win.cc [modify] https://crrev.com/4a129a005d6db99d797613f8ec05f1bd7f1f9888/chrome/installer/util/install_util.cc [modify] https://crrev.com/4a129a005d6db99d797613f8ec05f1bd7f1f9888/chrome/installer/util/install_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77a6ae43fc44c8d9235f73407453f60e3535fe38 commit 77a6ae43fc44c8d9235f73407453f60e3535fe38 Author: Owen Min <zmin@chromium.org> Date: Thu Nov 22 13:46:12 2018 Add definition of 'CloudManagementEnrollmentMandatory' policy Bug: 904983 Change-Id: I340ccaeaf679bf1d63276daa223b360e80daad2b Reviewed-on: https://chromium-review.googlesource.com/c/1345411 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610398} [modify] https://crrev.com/77a6ae43fc44c8d9235f73407453f60e3535fe38/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/77a6ae43fc44c8d9235f73407453f60e3535fe38/chrome/test/data/policy/policy_test_cases.json [modify] https://crrev.com/77a6ae43fc44c8d9235f73407453f60e3535fe38/components/policy/core/browser/browser_policy_connector.cc [modify] https://crrev.com/77a6ae43fc44c8d9235f73407453f60e3535fe38/components/policy/core/common/policy_pref_names.cc [modify] https://crrev.com/77a6ae43fc44c8d9235f73407453f60e3535fe38/components/policy/core/common/policy_pref_names.h [modify] https://crrev.com/77a6ae43fc44c8d9235f73407453f60e3535fe38/components/policy/resources/policy_templates.json [modify] https://crrev.com/77a6ae43fc44c8d9235f73407453f60e3535fe38/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f5cebda8291663b4dd4a428a3ce8b9d1572f15a commit 2f5cebda8291663b4dd4a428a3ce8b9d1572f15a Author: Owen Min <zmin@chromium.org> Date: Tue Nov 27 21:02:15 2018 Load cloud management enrollment option on Linux Read $policy_dir/enrollment/CloudManagementEnrollmentOptions file. If it contains 'Mandatory', then the enrollment is forced. Bug: 904983 Change-Id: I44452f1c016a0432bf541b3ee6605f24ec3898ff Reviewed-on: https://chromium-review.googlesource.com/c/1349773 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#611313} [modify] https://crrev.com/2f5cebda8291663b4dd4a428a3ce8b9d1572f15a/chrome/browser/policy/browser_dm_token_storage_linux.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e15b412ecb75b06939896716f958a8cd4930cd91 commit e15b412ecb75b06939896716f958a8cd4930cd91 Author: Owen Min <zmin@chromium.org> Date: Wed Nov 28 02:20:53 2018 Load cloud management enrollment option on Mac Load CloudManagementEnrollmentMandatory policy first. If not set, read the /Library/Google/Chrome/CloudManagementEnrollmentOptions file. If it contains Mandatory, then the enrollment is forced. Also, always use com.google.Chrome as the bundle Id of Preference. Bug: 904983 Change-Id: I1d45c48bef30c78ecddcb501e091a1132805b0ef Reviewed-on: https://chromium-review.googlesource.com/c/1348910 Reviewed-by: Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611520} [modify] https://crrev.com/e15b412ecb75b06939896716f958a8cd4930cd91/chrome/browser/policy/browser_dm_token_storage_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cf78d2bba6e595b4587dcbebc05743309d124fe commit 4cf78d2bba6e595b4587dcbebc05743309d124fe Author: Alexander Hendrich <hendrich@chromium.org> Date: Mon Jan 07 15:40:57 2019 Add clarification comment to 'CloudManagementEnrollmentMandatory' policy See https://critique.corp.google.com/#review/223932002/depot/google3/ccc/hosted/policies/services/chrome/chrome_settings.proto&l=7818R&vl=r214&vr=s1 for reference. Bug: 904983 Change-Id: Iacec0ee068bef87aa0dbc6031a8be36dca585eac Reviewed-on: https://chromium-review.googlesource.com/c/1377414 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#620329} [modify] https://crrev.com/4cf78d2bba6e595b4587dcbebc05743309d124fe/components/policy/resources/policy_templates.json
Comment 1 by bugdroid1@chromium.org
, Nov 14