check failure in GLES2Implementation::DeleteTextures |
||||
Issue descriptionRepro step: 1) Run debug build of chrome for chromeos on glinux with --ash-debug-shortcuts flag 2) open one browser window 3) swtich to tablet using ctrl-alt-shift-t 4) go overview mode by clicking overview button 5) in overview mode, click "launcher" button dcastagna@, can you take a look? [194395:194395:1113/121741.269172:ERROR:textfield.cc(1777)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [194395:194395:1113/121749.255635:FATAL:gles2_implementation_impl_autogen.h(579)] Check failed: textures[i] != 0. #0 0x7fb1fce38d5f base::debug::StackTrace::StackTrace() #1 0x7fb1fcd6892b logging::LogMessage::~LogMessage() #2 0x7fb1f5043510 gpu::gles2::GLES2Implementation::DeleteTextures() #3 0x7fb1f9b56bee skia_bindings::GLES2ImplementationWithGrContextSupport::DeleteTextures() #4 0x7fb1ed72fc91 viz::GLRenderer::UpdateRPDQShadersForBlending() #5 0x7fb1ed72f0e7 viz::GLRenderer::DrawRenderPassQuadInternal() #6 0x7fb1ed72abdc viz::GLRenderer::DrawRenderPassQuad() #7 0x7fb1ed729e62 viz::GLRenderer::DoDrawQuad() #8 0x7fb1ed70fb96 viz::DirectRenderer::DrawRenderPass() #9 0x7fb1ed70ecdb viz::DirectRenderer::DrawRenderPassAndExecuteCopyRequests() #10 0x7fb1ed70e4e1 viz::DirectRenderer::DrawFrame() #11 0x7fb1ed714779 viz::Display::DrawAndSwap() #12 0x7fb1ed7234b5 viz::DisplayScheduler::DrawAndSwap() #13 0x7fb1ed722b97 viz::DisplayScheduler::AttemptDrawAndSwap() #14 0x7fb1ed7223d6 viz::DisplayScheduler::OnBeginFrameDeadline() #15 0x7fb1ed7252d7 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz16DisplaySchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #16 0x7fb1ed72585f _ZN4base8internal22CancelableCallbackImplINS_17RepeatingCallbackIFvvEEEE16ForwardRepeatingIJEEEvDpT_ #17 0x7fb1ed7252d7 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz16DisplaySchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #18 0x7fb1fcd4bc3a base::debug::TaskAnnotator::RunTask() #19 0x7fb1fcd77def base::MessageLoopImpl::RunTask() #20 0x7fb1fcd78383 base::MessageLoopImpl::DoWork() #21 0x7fb1fce5c5b9 base::MessagePumpLibevent::Run() #22 0x7fb1fcd77994 base::MessageLoopImpl::Run() #23 0x7fb1fcda9579 base::RunLoop::Run() #24 0x55aafabda9dd ChromeBrowserMainParts::MainMessageLoopRun() #25 0x7fb1f9cd28b7 content::BrowserMainLoop::RunMainMessageLoopParts() #26 0x7fb1f9cd53b6 content::BrowserMainRunnerImpl::Run() #27 0x7fb1f9ccee79 content::BrowserMain() #28 0x7fb1fa7a0ac6 content::ContentMainRunnerImpl::Run() #29 0x7fb1ed2eff46 service_manager::Main() #30 0x7fb1fa79edb4 content::ContentMain() #31 0x55aaf9da8c33 ChromeMain #32 0x7fb1ed8b32b1 __libc_start_main #33 0x55aaf9da8aaa _start
,
Nov 27
I can't repro but this is likely a regression and it should be fixed with crrev.com/c/1351711
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ceb3da6c512ed69d102f0501e83efdf61ed7dd95 commit ceb3da6c512ed69d102f0501e83efdf61ed7dd95 Author: Daniele Castagna <dcastagna@chromium.org> Date: Tue Nov 27 23:37:52 2018 viz: Fix params->background_texture == 0 case In crrev.com/c/1296679 we removed unnecessary code given the assumption that backdrop_texture could never be 0. Unfortunately we missed the case where background_rect is empty, and we still can have params->background_texture equal to 0. This patch brings back that check. Bug: 908293 , 904981 Change-Id: I94a1109c839337b77589c69fa607d7dc074c0daf Reviewed-on: https://chromium-review.googlesource.com/c/1351711 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#611417} [modify] https://crrev.com/ceb3da6c512ed69d102f0501e83efdf61ed7dd95/components/viz/service/display/gl_renderer.cc
,
Nov 28
,
Nov 28
This should be fixed with the patch in #3. Please reopen if that's not the case.
,
Nov 28
Verified that it fixed the issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by michae...@chromium.org
, Nov 21