This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64d96743f14f6d1f44521a1fab856853063fc302

commit 64d96743f14f6d1f44521a1fab856853063fc302
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Nov 15 22:00:40 2018

Download Home : Video layout bug causing shift of content and menu button

Long title text on the video item causes weird shift in the image view and
also hides the three dot menu button that is located on the right. Didn't
find a way to fix this in GridLayout. Changed this to use LinearLayout
which will fix this issue.

We also need to do the same fix for in-progress video layout where the
cancel button is getting hidden by the long text.

Bug:  904979 
Change-Id: I1e2974c1772d5745242d106ee8e35fde58b5c1cf
Reviewed-on: https://chromium-review.googlesource.com/c/1334828
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608533}
[modify] https://crrev.com/64d96743f14f6d1f44521a1fab856853063fc302/chrome/android/java/res_download/layout/download_manager_in_progress_video_item.xml
[modify] https://crrev.com/64d96743f14f6d1f44521a1fab856853063fc302/chrome/android/java/res_download/layout/download_manager_video_item.xml

Issue is now not reproducible on latest M72-72.0.3615.0, but still exists on latest M71-71.0.3578.61

Approved for merge to 71, branch 3578.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035d534d2ed3e1ae604cdf4abb06792325019c06

commit 035d534d2ed3e1ae604cdf4abb06792325019c06
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Wed Nov 21 20:42:24 2018

Download Home : Video layout bug causing shift of content and menu button

Long title text on the video item causes weird shift in the image view and
also hides the three dot menu button that is located on the right. Didn't
find a way to fix this in GridLayout. Changed this to use LinearLayout
which will fix this issue.

We also need to do the same fix for in-progress video layout where the
cancel button is getting hidden by the long text.

TBR=shaktisahu@chromium.org

(cherry picked from commit 64d96743f14f6d1f44521a1fab856853063fc302)

Bug:  904979 
Change-Id: I1e2974c1772d5745242d106ee8e35fde58b5c1cf
Reviewed-on: https://chromium-review.googlesource.com/c/1334828
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#608533}
Reviewed-on: https://chromium-review.googlesource.com/c/1347442
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#790}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/035d534d2ed3e1ae604cdf4abb06792325019c06/chrome/android/java/res_download/layout/download_manager_in_progress_video_item.xml
[modify] https://crrev.com/035d534d2ed3e1ae604cdf4abb06792325019c06/chrome/android/java/res_download/layout/download_manager_video_item.xml

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/035d534d2ed3e1ae604cdf4abb06792325019c06

Commit: 035d534d2ed3e1ae604cdf4abb06792325019c06
Author: shaktisahu@chromium.org
Commiter: shaktisahu@chromium.org
Date: 2018-11-21 20:42:24 +0000 UTC

Download Home : Video layout bug causing shift of content and menu button

Long title text on the video item causes weird shift in the image view and
also hides the three dot menu button that is located on the right. Didn't
find a way to fix this in GridLayout. Changed this to use LinearLayout
which will fix this issue.

We also need to do the same fix for in-progress video layout where the
cancel button is getting hidden by the long text.

TBR=shaktisahu@chromium.org

(cherry picked from commit 64d96743f14f6d1f44521a1fab856853063fc302)

Bug:  904979 
Change-Id: I1e2974c1772d5745242d106ee8e35fde58b5c1cf
Reviewed-on: https://chromium-review.googlesource.com/c/1334828
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#608533}
Reviewed-on: https://chromium-review.googlesource.com/c/1347442
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#790}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

This issue is now not reproducible in both orientation modes in latest 71.0.3578.68, Verified on Asus Zenfone2(ZE550ML)/LRX21V and Samsung Galaxy tab S2(SM-T815Y)/NRD90M

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe841098e3425af8955d66010f0535f007d6634

commit cbe841098e3425af8955d66010f0535f007d6634
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Mon Nov 26 19:09:46 2018

Revert "Download Home : Video layout bug causing shift of content and menu button"

This reverts commit 035d534d2ed3e1ae604cdf4abb06792325019c06.

Reason for revert: Crash due to use of ChromeImageButton

Original change's description:
> Download Home : Video layout bug causing shift of content and menu button
> 
> Long title text on the video item causes weird shift in the image view and
> also hides the three dot menu button that is located on the right. Didn't
> find a way to fix this in GridLayout. Changed this to use LinearLayout
> which will fix this issue.
> 
> We also need to do the same fix for in-progress video layout where the
> cancel button is getting hidden by the long text.
> 
> TBR=shaktisahu@chromium.org
> 
> (cherry picked from commit 64d96743f14f6d1f44521a1fab856853063fc302)
> 
> Bug:  904979 
> Change-Id: I1e2974c1772d5745242d106ee8e35fde58b5c1cf
> Reviewed-on: https://chromium-review.googlesource.com/c/1334828
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#608533}
> Reviewed-on: https://chromium-review.googlesource.com/c/1347442
> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3578@{#790}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

TBR=dtrainor@chromium.org,shaktisahu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  904979 
Change-Id: I61d65068e7de8ae97f3d18c495dbf705ad0062a4
Reviewed-on: https://chromium-review.googlesource.com/c/1349457
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#810}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/cbe841098e3425af8955d66010f0535f007d6634/chrome/android/java/res_download/layout/download_manager_in_progress_video_item.xml
[modify] https://crrev.com/cbe841098e3425af8955d66010f0535f007d6634/chrome/android/java/res_download/layout/download_manager_video_item.xml

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/cbe841098e3425af8955d66010f0535f007d6634

Commit: cbe841098e3425af8955d66010f0535f007d6634
Author: shaktisahu@chromium.org
Commiter: shaktisahu@chromium.org
Date: 2018-11-26 19:09:46 +0000 UTC

Revert "Download Home : Video layout bug causing shift of content and menu button"

This reverts commit 035d534d2ed3e1ae604cdf4abb06792325019c06.

Reason for revert: Crash due to use of ChromeImageButton

Original change's description:
> Download Home : Video layout bug causing shift of content and menu button
> 
> Long title text on the video item causes weird shift in the image view and
> also hides the three dot menu button that is located on the right. Didn't
> find a way to fix this in GridLayout. Changed this to use LinearLayout
> which will fix this issue.
> 
> We also need to do the same fix for in-progress video layout where the
> cancel button is getting hidden by the long text.
> 
> TBR=shaktisahu@chromium.org
> 
> (cherry picked from commit 64d96743f14f6d1f44521a1fab856853063fc302)
> 
> Bug:  904979 
> Change-Id: I1e2974c1772d5745242d106ee8e35fde58b5c1cf
> Reviewed-on: https://chromium-review.googlesource.com/c/1334828
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#608533}
> Reviewed-on: https://chromium-review.googlesource.com/c/1347442
> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3578@{#790}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

TBR=dtrainor@chromium.org,shaktisahu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  904979 
Change-Id: I61d65068e7de8ae97f3d18c495dbf705ad0062a4
Reviewed-on: https://chromium-review.googlesource.com/c/1349457
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#810}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

This is observed again from M71 71.0.3578.73 on changing device orientation, hence reopening it.

We have already fixed this in 72 and we are planning for only 1% experimental in 71. Moreover, this issue occurs only when the file name is too long for the videos. I wouldn't block the 71 stable on this as we are already past the stable cut.

Removing RBS as per #16