New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904963 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 610495



Sign in to add a comment

Update Public Suffix for M-71 before Stable

Project Member Reported by marti...@chromium.org, Nov 13

Issue description

(Reposting explanation from Umbrella Bug, Issue 610495)

Chrome ships a copy of the Public Suffix List ( https://publicsuffix.org ) for a variety of security purposes. Because it's key to web origin security, it needs to be reliably available before any networking, and is thus baked into the binary (rather than a component updater).

The list changes over time, and so this list must be updated every release to include the latest changes.

This is a data file-only change that includes the expressed security policies of domain holders, from the domain holders.

For every release, a bug will be created to track that releases' updates to the PSL.
 
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you.

Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.

Cc: benmason@chromium.org
Labels: Target-71
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you.

Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.
Labels: Hotlist-ConOps
Friendly ping to look into this issue and to provide further update on this issue as it has been marked as a stable blocker.

Thanks!
I have a patch ready for this.

The PSL updates are small data file-only changes that are merged relatively late to ensure the list is as up-to-date as possible. See issue 610495 for more info and the merge history for previous releases.
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fda95a199ab2d982413680d9436a1d79e0f2b695

commit fda95a199ab2d982413680d9436a1d79e0f2b695
Author: Martijn Croonen <martijnc@chromium.org>
Date: Wed Nov 21 16:23:52 2018

Refresh Public Suffix List to the latest version.

This updates from revision
6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03)

to revision
5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08)

Bug:  904963 
Change-Id: I7a7caf8e98b35791ccb95e6f0d5ce48647d237cc
Reviewed-on: https://chromium-review.googlesource.com/c/1343098
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Martijn Croonen <martijnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610099}
[modify] https://crrev.com/fda95a199ab2d982413680d9436a1d79e0f2b695/net/base/registry_controlled_domains/effective_tld_names.dat
[modify] https://crrev.com/fda95a199ab2d982413680d9436a1d79e0f2b695/net/base/registry_controlled_domains/effective_tld_names.gperf

Labels: Merge-Approved-71
Approved for merge to 71, branch 3578.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 21

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a451306ed9c5832cc1bee124d90637c5edd70e77

commit a451306ed9c5832cc1bee124d90637c5edd70e77
Author: Martijn Croonen <martijnc@chromium.org>
Date: Wed Nov 21 19:30:42 2018

Refresh Public Suffix List to the latest version.

This updates from revision
6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03)

to revision
5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08)

Bug:  904963 
Change-Id: I7a7caf8e98b35791ccb95e6f0d5ce48647d237cc
Reviewed-on: https://chromium-review.googlesource.com/c/1343098
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Martijn Croonen <martijnc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#610099}(cherry picked from commit fda95a199ab2d982413680d9436a1d79e0f2b695)
Reviewed-on: https://chromium-review.googlesource.com/c/1347350
Reviewed-by: Martijn Croonen <martijnc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#789}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/a451306ed9c5832cc1bee124d90637c5edd70e77/net/base/registry_controlled_domains/effective_tld_names.dat
[modify] https://crrev.com/a451306ed9c5832cc1bee124d90637c5edd70e77/net/base/registry_controlled_domains/effective_tld_names.gperf

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a451306ed9c5832cc1bee124d90637c5edd70e77

Commit: a451306ed9c5832cc1bee124d90637c5edd70e77
Author: martijnc@chromium.org
Commiter: martijnc@chromium.org
Date: 2018-11-21 19:30:42 +0000 UTC

Refresh Public Suffix List to the latest version.

This updates from revision
6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03)

to revision
5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08)

Bug:  904963 
Change-Id: I7a7caf8e98b35791ccb95e6f0d5ce48647d237cc
Reviewed-on: https://chromium-review.googlesource.com/c/1343098
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Martijn Croonen <martijnc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#610099}(cherry picked from commit fda95a199ab2d982413680d9436a1d79e0f2b695)
Reviewed-on: https://chromium-review.googlesource.com/c/1347350
Reviewed-by: Martijn Croonen <martijnc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#789}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Can this be marked as fixed now as it is already merged to M71?
NextAction: ----
Status: Fixed (was: Started)

Sign in to add a comment