New issue
Advanced search Search tips

Issue 904951 link

Starred by 1 user
Status: Fixed
Owner:
obru...@igalia.com
Closed: Nov 14
Cc:
r...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 901409



Sign in to add a comment

NGConstraintSpace has LTR direction for inline children even if block container is RTL

Project Member Reported by obru...@igalia.com, Nov 13 
What steps will reproduce the problem?
(1) Create a block box with direction:rtl
(2) Create an inline element inside it

What is the expected result?

The NGConstraintSpace for the child has rtl direction

What happens instead?

The NGConstraintSpace for the child has ltr direction

This affects my patch for  issue 901409 , because I rely on the NGConstraintSpace direction in order to resolve things like float:inline-start
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8a6fb048f9c2198ea00fbcbe9bdf891f2d6d39d

commit f8a6fb048f9c2198ea00fbcbe9bdf891f2d6d39d
Author: Oriol Brufau <obrufau@igalia.com>
Date: Wed Nov 14 00:34:45 2018

Set NGConstraintSpace's direction for inline children of a block container

Currently the NGConstraintSpace's direction for inline children of a
block containeris is LTR even if the block container has RTL direction.

BUG= 904951 

Change-Id: I271f2e2f4b30df6513d84ea149dc73b9532a4ce0
Reviewed-on: https://chromium-review.googlesource.com/c/1334508
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607833}
[modify] https://crrev.com/f8a6fb048f9c2198ea00fbcbe9bdf891f2d6d39d/third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc

Comment 2 by obru...@igalia.com, Nov 14

Status: Fixed (was: Started)
►

Sign in to add a comment