New issue
Advanced search Search tips

Issue 904950 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: 5
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 914988

Blocking:
issue 904881
issue 913643


Show other hotlists

Hotlists containing this issue:
CrOSParallelCQ


Sign in to add a comment

PublishUprevChanges

Project Member Reported by cindyb@google.com, Nov 13

Issue description

Sync to ToT (with just-merged CLs), Uprev, push uprevs
 
Status: Available (was: Untriaged)
Owner: athilenius@chromium.org
Status: Assigned (was: Available)
This will happen in the Annealing Builder.
EstimatedDays: 5
Blocking: 913643
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/recipes/+/a6412a509e614120c2eb5101915d2270b25d980f

commit a6412a509e614120c2eb5101915d2270b25d980f
Author: Alec Thilenius <athilenius@google.com>
Date: Thu Dec 13 17:51:44 2018

Added uprev_portage_packages to cros recipes module

Added a `uprev_portage_packages` method to the `cros` recipes module.
This will cause all packages to be upreved for all boards.

Bug: 904950

Change-Id: I09261d01f119e4d46f6ee5c1a59b745590c6b8c6
Reviewed-on: https://chromium-review.googlesource.com/c/1374929
Reviewed-by: Lann Martin <lannm@chromium.org>
Commit-Queue: Alec Thilenius <athilenius@google.com>
Tested-by: Alec Thilenius <athilenius@google.com>

[modify] https://crrev.com/a6412a509e614120c2eb5101915d2270b25d980f/recipes/annealing.py
[modify] https://crrev.com/a6412a509e614120c2eb5101915d2270b25d980f/README.recipes.md
[modify] https://crrev.com/a6412a509e614120c2eb5101915d2270b25d980f/recipe_modules/cros/api.py
[modify] https://crrev.com/a6412a509e614120c2eb5101915d2270b25d980f/recipe_modules/cros/examples/full.expected/basic.json
[modify] https://crrev.com/a6412a509e614120c2eb5101915d2270b25d980f/recipe_modules/cros/examples/full.py

Status: Started (was: Assigned)
Blockedon: 914988
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/recipes/+/b25c1f4ed231283c7be9dd38015eb22e6cb646c3

commit b25c1f4ed231283c7be9dd38015eb22e6cb646c3
Author: Alec Thilenius <athilenius@google.com>
Date: Tue Dec 18 18:45:54 2018

Add push_portage_package_uprevs to cros recipe module

Add a push_portage_package_uprevs method to the cros recipe module. For
now it uses `cros_mark_as_stable push` but we would like to later handle
the pushes from recipe. crbug.com/914988 is open to track that.

Bug: 904950
Change-Id: I138cb4a4d95f1c4a0c22973eaab5d55971222320
Reviewed-on: https://chromium-review.googlesource.com/c/1376774
Commit-Queue: Alec Thilenius <athilenius@google.com>
Tested-by: Alec Thilenius <athilenius@google.com>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/b25c1f4ed231283c7be9dd38015eb22e6cb646c3/recipes/annealing.expected/basic.json
[modify] https://crrev.com/b25c1f4ed231283c7be9dd38015eb22e6cb646c3/recipes/annealing.py
[modify] https://crrev.com/b25c1f4ed231283c7be9dd38015eb22e6cb646c3/recipe_modules/cros/api.py
[modify] https://crrev.com/b25c1f4ed231283c7be9dd38015eb22e6cb646c3/recipe_modules/cros/examples/full.py
[modify] https://crrev.com/b25c1f4ed231283c7be9dd38015eb22e6cb646c3/README.recipes.md
[modify] https://crrev.com/b25c1f4ed231283c7be9dd38015eb22e6cb646c3/recipe_modules/cros/examples/full.expected/basic.json

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/recipes/+/09c997e645c6eb6929876908495233305fbab8d5

commit 09c997e645c6eb6929876908495233305fbab8d5
Author: Alec Thilenius <athilenius@google.com>
Date: Thu Dec 20 19:43:23 2018

More gooder nesting for git transaction module

The git_txn module step name nesting was a little confusing. Made it so
that on the first run it's labeled simply 'git transaction' and only on
the retry runs does it print things like 'git transaction retry 1 of 2'.

Bug: 904950
Change-Id: I87d1895861d7e3672e7a992998974ab7824fab83
Reviewed-on: https://chromium-review.googlesource.com/c/1387209
Reviewed-by: Lann Martin <lannm@chromium.org>
Commit-Queue: Alec Thilenius <athilenius@google.com>
Tested-by: Alec Thilenius <athilenius@google.com>

[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipes/annealing.expected/basic.json
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipe_modules/git_txn/examples/full.expected/basic.json
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipe_modules/git_txn/examples/full.expected/retry too many times.json
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipe_modules/git_txn/examples/full.expected/retry succeed.json
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipe_modules/git_txn/api.py
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipe_modules/git_txn/examples/full.py
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipe_modules/git_txn/examples/full.expected/other failure.json
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/README.recipes.md
[modify] https://crrev.com/09c997e645c6eb6929876908495233305fbab8d5/recipe_modules/git_txn/examples/full.expected/rejected no update.json

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/recipes/+/3d73f585d7fef903e869528dc8a52b324fd0c931

commit 3d73f585d7fef903e869528dc8a52b324fd0c931
Author: Alec Thilenius <athilenius@google.com>
Date: Thu Dec 20 21:14:44 2018

Add a short-circuit to non-changed file commits/pushes

Add a method to the `git` module to check if a file at the given path
has changed from `HEAD` and use that info to short-circuit the
`git_txn.update_ref_write_file` method.

Bug: 904950
Change-Id: Iee7c15fe125c30836c647e010644e0ba742fbff2
Reviewed-on: https://chromium-review.googlesource.com/c/1387626
Reviewed-by: Alec Thilenius <athilenius@google.com>
Commit-Queue: Alec Thilenius <athilenius@google.com>
Tested-by: Alec Thilenius <athilenius@google.com>

[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipes/annealing.expected/basic.json
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git/examples/full.py
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git_txn/examples/full.expected/basic.json
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git_txn/examples/full.expected/retry succeed.json
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git_txn/api.py
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git_txn/examples/full.py
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/README.recipes.md
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git/examples/full.expected/basic.json
[add] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git_txn/examples/full.expected/update ref has diff.json
[modify] https://crrev.com/3d73f585d7fef903e869528dc8a52b324fd0c931/recipe_modules/git/api.py

Sign in to add a comment