New issue
Advanced search Search tips

Issue 904898 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Nov 16
Cc:
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

'paint-order' serialization is incorrect (not canonical/shortest form)

 
WPT import https://crrev.com/c/1333891 introduced new failures in external/wpt/svg:

List of new failures:
external/wpt/svg/painting/inheritance.svg new failing tests: https://crrev.com/c/1333891/4/third_party/WebKit/LayoutTests/external/wpt/svg/painting/inheritance-expected.txt

This import contains upstream changes from bbaede37efaff6c5a2d592e3ce8071f379329812 to 7ecc4ecf9b74d4777ace24b5a1b29f932acbb9e7:
Merge pull request #14032 from ewilligers/svg-text-inheritance: https://github.com/web-platform-tests/wpt/commit/7ecc4ecf9b74d4777ace24b5a1b29f932acbb9e7
Merge pull request #14031 from ewilligers/painting-inheritance: https://github.com/web-platform-tests/wpt/commit/0d5c1ad0b29a21ff86e117d2dcbc2a87348d695c
disable Firefox WebRTC ICE logging to reduce log size: https://github.com/web-platform-tests/wpt/commit/414fbd58da64c7e13d3e8020fe216268fcdf6ad4
SVG Text: inheritance, initial values: https://github.com/web-platform-tests/wpt/commit/5124d93232840b975d3e14f270a4e5ee9e22bc1b [affecting this directory]
SVG Painting: inheritance and initial values: https://github.com/web-platform-tests/wpt/commit/1794ecf7c674828b4ef3142b676c2c17f6278c3f [affecting this directory]

Comment 1 by f...@opera.com, Nov 14

Labels: Pri-2 Type-Bug
Status: Available (was: Untriaged)
Summary: 'paint-order' serialization is incorrect (not canonical/shortest form) (was: [WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1333891)
Failures:

FAIL Property paint-order has initial value normal assert_equals: expected "normal" but got "fill stroke markers"
FAIL Property paint-order inherits assert_equals: expected "markers stroke" but got "markers stroke fill"

  So paint-order serialization is not "canonical enough".

FAIL Property image-rendering inherits assert_equals: expected "optimizequality" but got "auto"

  This is issue 901669.

Comment 2 by f...@opera.com, Nov 14

Owner: f...@opera.com
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adb8cf8d8cce02930e524e505f443ba3cc2d67a6

commit adb8cf8d8cce02930e524e505f443ba3cc2d67a6
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri Nov 16 01:50:37 2018

Fix serialization of computed style for 'paint-order'

We were always serializing as the completed (all keywords present) form,
which is not the shortest canonical form.

 https://svgwg.org/svg2-draft/painting.html#PaintOrder

Fold the ComputedStyleUtils helper into the PaintOrder CSSProperty
class, since this is very specific to this property.

Matches WebKit and almost Gecko (which seems to handle some "two
keyword" cases differently.)

Bug:  904898 
Change-Id: Ib796a111e601485e339fdf2739a587fb5f893b8a
Reviewed-on: https://chromium-review.googlesource.com/c/1335579
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608623}
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/animations/svg/svg-presentation-attribute-animation.html
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/paint-order-expected.txt
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/external/wpt/svg/painting/inheritance-expected.txt
[add] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/external/wpt/svg/painting/scripted/paint-order-computed-value-01.svg
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[delete] https://crrev.com/0b639f6da2323e82159e1b6748050c6198f3aa1a/third_party/WebKit/LayoutTests/svg/css/script-tests/svg-paint-order.js
[delete] https://crrev.com/0b639f6da2323e82159e1b6748050c6198f3aa1a/third_party/WebKit/LayoutTests/svg/css/svg-paint-order-expected.txt
[delete] https://crrev.com/0b639f6da2323e82159e1b6748050c6198f3aa1a/third_party/WebKit/LayoutTests/svg/css/svg-paint-order.html
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/blink/renderer/core/css/properties/computed_style_utils.cc
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/blink/renderer/core/css/properties/computed_style_utils.h
[modify] https://crrev.com/adb8cf8d8cce02930e524e505f443ba3cc2d67a6/third_party/blink/renderer/core/css/properties/longhands/paint_order_custom.cc

Comment 4 by f...@opera.com, Nov 16

Status: Fixed (was: Assigned)
►

Sign in to add a comment