A bunch of table-related functions were recently added to ui::AXNode, and they have unit tests - but all of the DumpAccessibilityTree tests still dump "raw" table attributes. We should update them to dump computed table attributes instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd5349d6feccf5413d3c8733f958e7bab286f9e2 commit fd5349d6feccf5413d3c8733f958e7bab286f9e2 Author: Aran Gilman <gilmanmh@google.com> Date: Tue Nov 27 16:39:42 2018 Display computed table attributes instead of raw table attributes in Blink tests. Also move a helper method out of the class definition and into an anonymous namespace in the implementation, remove a fixed TODO, and let the autoformatter fix some formatting errors. Bug: 904896 Change-Id: I1384de5b4b457bf78f79e7fe42cc26d72850ed1e Reviewed-on: https://chromium-review.googlesource.com/c/1343356 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#611141} [modify] https://crrev.com/fd5349d6feccf5413d3c8733f958e7bab286f9e2/content/browser/accessibility/accessibility_tree_formatter_blink.cc [modify] https://crrev.com/fd5349d6feccf5413d3c8733f958e7bab286f9e2/content/browser/accessibility/accessibility_tree_formatter_blink.h [modify] https://crrev.com/fd5349d6feccf5413d3c8733f958e7bab286f9e2/content/test/data/accessibility/aria/table-column-hidden-expected-blink.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa9db4fee115ad4398d8cdfe34b597c94e33caa5 commit aa9db4fee115ad4398d8cdfe34b597c94e33caa5 Author: Aran Gilman <gilmanmh@google.com> Date: Mon Dec 10 20:44:44 2018 Compute table-related ARIA attributes in Mac-specific code. This should make the Mac AXTree's output the same as in Blink for the impacted attributes, since the Blink formatter already computes them. Bug: 904896 Change-Id: I94dde0d392c6bebcb0bf7601165b09d17af5b9c9 Reviewed-on: https://chromium-review.googlesource.com/c/1366483 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615240} [modify] https://crrev.com/aa9db4fee115ad4398d8cdfe34b597c94e33caa5/content/browser/accessibility/browser_accessibility_cocoa.mm [modify] https://crrev.com/aa9db4fee115ad4398d8cdfe34b597c94e33caa5/content/test/data/accessibility/aria/table-column-hidden-expected-mac.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958 commit 01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958 Author: Aran Gilman <gilmanmh@google.com> Date: Tue Dec 18 20:23:04 2018 Add methods for table-related attributes to AXPlatformNodeDelegate. The idea is to allow code that does not assume the presence of an underlying AXNode to request these attributes to be computed. In the future we may want to implement this some other way e.g. some kind of TableProperties class, but this way is simplest and unblocks other dependent changes. Bug: 904896 Change-Id: Id84199d50980ed6c7bc9e9dcf5b996f14bedaee2 Reviewed-on: https://chromium-review.googlesource.com/c/1376323 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#617604} [modify] https://crrev.com/01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958/content/browser/accessibility/accessibility_tree_formatter_blink.cc [modify] https://crrev.com/01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958/content/browser/accessibility/browser_accessibility.cc [modify] https://crrev.com/01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958/content/browser/accessibility/browser_accessibility.h [modify] https://crrev.com/01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958/ui/accessibility/platform/ax_platform_node_delegate.h [modify] https://crrev.com/01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958/ui/accessibility/platform/ax_platform_node_delegate_base.cc [modify] https://crrev.com/01b8ba7bc37fb987c6bf1ccc0fe802bea8f84958/ui/accessibility/platform/ax_platform_node_delegate_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3274396f42c754db9666af2ff2b383d99b30baf9 commit 3274396f42c754db9666af2ff2b383d99b30baf9 Author: Aran Gilman <gilmanmh@google.com> Date: Wed Dec 19 21:05:17 2018 Move int attribute computation method to its own file. The main current use case outside of the Blink tree formatter is the Windows attribute computation code in ui/accessibility/platform, which will be updated in a follow-up CL. Bug: 904896 Change-Id: Ic756cff6d1a15c8ce6890238ef22b272496f32d5 Reviewed-on: https://chromium-review.googlesource.com/c/1376651 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#617945} [modify] https://crrev.com/3274396f42c754db9666af2ff2b383d99b30baf9/content/browser/accessibility/accessibility_tree_formatter_blink.cc [modify] https://crrev.com/3274396f42c754db9666af2ff2b383d99b30baf9/ui/accessibility/BUILD.gn [add] https://crrev.com/3274396f42c754db9666af2ff2b383d99b30baf9/ui/accessibility/platform/compute_attributes.cc [add] https://crrev.com/3274396f42c754db9666af2ff2b383d99b30baf9/ui/accessibility/platform/compute_attributes.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11dc43959e32bf2b960338ca0a630b36aae69002 commit 11dc43959e32bf2b960338ca0a630b36aae69002 Author: Aran Gilman <gilmanmh@google.com> Date: Wed Dec 19 23:47:38 2018 Compute table-related attributes in AXPlatformNodeBase. Linux and Mac already compute table-related attributes via other code, so this basically makes Windows behave the same as other platforms. Bug: 904896 Change-Id: I05e0d2979cdb949d1ba6e9cdc9d2ea49dc957052 Reviewed-on: https://chromium-review.googlesource.com/c/1376490 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618011} [modify] https://crrev.com/11dc43959e32bf2b960338ca0a630b36aae69002/content/test/data/accessibility/aria/aria-rowtext-expected-win.txt [modify] https://crrev.com/11dc43959e32bf2b960338ca0a630b36aae69002/content/test/data/accessibility/aria/table-column-hidden-expected-win.txt [modify] https://crrev.com/11dc43959e32bf2b960338ca0a630b36aae69002/ui/accessibility/platform/ax_platform_node_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb537be6e334294bdfd79fc42f18dee48e6dd039 commit cb537be6e334294bdfd79fc42f18dee48e6dd039 Author: Aran Gilman <gilmanmh@google.com> Date: Fri Dec 21 23:54:06 2018 Move unrelated expectations from one test to a separate test. AccessibilityTableColumnHidden should fail when hiding the column causes incorrect behavior, not when unrelated changes to attribute computation change the value of row index. However, no other tests caught the discrepancy between set and computed aria attributes, so a new test for that is also added. Bug: 904896 Change-Id: I6af6fa8260c4eeea477f19ffe9dfd8ce621052f9 Reviewed-on: https://chromium-review.googlesource.com/c/1376739 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618681} [modify] https://crrev.com/cb537be6e334294bdfd79fc42f18dee48e6dd039/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [add] https://crrev.com/cb537be6e334294bdfd79fc42f18dee48e6dd039/content/test/data/accessibility/aria/aria-mismatched-table-attr-expected-blink.txt [add] https://crrev.com/cb537be6e334294bdfd79fc42f18dee48e6dd039/content/test/data/accessibility/aria/aria-mismatched-table-attr-expected-mac.txt [add] https://crrev.com/cb537be6e334294bdfd79fc42f18dee48e6dd039/content/test/data/accessibility/aria/aria-mismatched-table-attr-expected-win.txt [add] https://crrev.com/cb537be6e334294bdfd79fc42f18dee48e6dd039/content/test/data/accessibility/aria/aria-mismatched-table-attr.html [modify] https://crrev.com/cb537be6e334294bdfd79fc42f18dee48e6dd039/content/test/data/accessibility/aria/table-column-hidden.html
Comment 1 by gilmanmh@google.com
, Nov 15Status: Assigned (was: Available)