New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove the screenlockPrivate API

Project Member Reported by jhawkins@chromium.org, Nov 13

Issue description

This API is now unused and should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d

commit 08d77f2bf2c8fcc644508037e7df7fb4619b1e1d
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Nov 16 17:16:51 2018

Extensions: Remove screenlockPrivate API.

This is no longer used.

R=tbarzic@chromium.org

Bug:  904892 
Test: none
Change-Id: Iac3088bdc2b198d0d5b37ab9cf18fba5c4c704c8
Reviewed-on: https://chromium-review.googlesource.com/c/1334331
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608821}
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[delete] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
[delete] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/common/extensions/api/api_sources.gni
[delete] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/chrome/common/extensions/api/screenlock_private.idl
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/common/extensions/docs/server2/known_broken_links.json
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/common/extensions/permissions/chrome_permission_message_rules.cc
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/chrome/test/BUILD.gn
[delete] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/chrome/test/data/extensions/api_test/screenlock_private/lock_unlock/manifest.json
[delete] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/chrome/test/data/extensions/api_test/screenlock_private/lock_unlock/test.js
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/tools/json_schema_compiler/js_util.py
[modify] https://crrev.com/08d77f2bf2c8fcc644508037e7df7fb4619b1e1d/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment