New issue
Advanced search Search tips

Issue 904888 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Small forms disabled for addresses still allow heuristics to run

Project Member Reported by se...@chromium.org, Nov 13

Issue description

In the exp group where we disable small forms for addresses, the server stops sending back predictions for address fields.

However, this still allows the heuristics to run, which is probably not what we want.

There are a few cases where this leads to a bad experience. For example, on mtgvault.com. If you try to add a name to your deck, it tries to autofill your name.
 
This is the prediction data for the field:

<input name="ctl00$ContentPlaceHolder1$TextBox_AutoCompleteMainDeck" type="text" id="ctl00_ContentPlaceHolder1_TextBox_AutoCompleteMainDeck" class="autocomplete ui-autocomplete-input" autocomplete="off" title="overall type: NAME_FULL
server type: NO_SERVER_DATA
heuristic type: CREDIT_CARD_NAME_FULL
label: Card Name
parseable name: TextBox_AutoCompleteMainDeck
section: ctl00$ContentPlaceHolder1$TextBox_AutoCompleteMainDeck_1-default
field signature: 823803194
form signature: 1038702490668747102" autofill-prediction="NAME_FULL">
This is what I see now:

<input name="ctl00$ContentPlaceHolder1$TextBox_AutoCompleteMainDeck" type="text" id="ctl00_ContentPlaceHolder1_TextBox_AutoCompleteMainDeck" class="autocomplete ui-autocomplete-input" autocomplete="off" title="overall type: UNKNOWN_TYPE
server type: NO_SERVER_DATA
heuristic type: UNKNOWN_TYPE
label: Card Name
parseable name: TextBox_AutoCompleteMainDeck
section: _1-default
field signature: 823803194
form signature: 5863649353546008412" autofill-prediction="UNKNOWN_TYPE">
Cc: parastoog@chromium.org
Hmm... looks like a change in the heuristics fixed this between the version you were running when you first noticed this and your version today.

IIRC, you said you're no running M70, but you're not sure which version you were running then.

I do notice that the form signature has changed as well.

A couple of other thoughts:

  - the input element seems to be embedded directly in the page
    (i.e., this is a formless form)

  - There are a bunch of other fields on the page, so the heuristics
    are probably being triggered due to the size of the formless
    form, not triggering for a small form.

 parastoog@, could any of your heuristics tweaks have fixed this?
How do you add a name to a deck? I don't use that website, not sure where you are referring to.
Cc: anthonyvd@chromium.org
You have to create an account, then on the home page hit "Create Deck", then the "Card Name" fields will be the ones triggering this. Let me know if I can help figure things out!

Sign in to add a comment