New issue
Advanced search Search tips

Issue 904885 link

Starred by 1 user
Status: Fixed
Owner:
danyao@chromium.org
Closed: Nov 14
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 807428



Sign in to add a comment

PasswordViewControllerTestCase fails with WKBasedNavigationManager

Project Member Reported by danyao@chromium.org, Nov 13 
Failing tests with --enable-features=SlimNavigationManager:

testIPadTappingOutsidePopOverDismissPasswordController
testPasswordControllerResumes
testPasswordControllerSupportsRotation
testManagePasswordsActionOpensPasswordSettings
testPasswordControllerKeepsRightSize
testPasswordControllerResumesWhenOtherPasswordsDismiss
testPasswordsViewControllerContainsManagePasswordsAction
testTappingKeyboardDismissPasswordControllerPopOver
testPasswordsViewControllerIsPresented
testPasswordControllerSupportsIFrameMessaging
testKeyboardIconDismissPasswordController
testPasswordControllerPauses

Comment 1 Deleted

Comment 2 by danyao@chromium.org, Nov 14 

These tests failures are not due to slim nav. They are failing on slim nav fyi bot due to missing command-line flags. This is being fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1335873.

I verified locally that these tests pass with --enable-features=SlimNavigationManager,AutofillManualFallback,WebFrameMessaging.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca0515b5a9c85095044fb5aaf367d077fdc388f7

commit ca0515b5a9c85095044fb5aaf367d077fdc388f7
Author: Danyao Wang <danyao@chromium.org>
Date: Wed Nov 14 21:01:39 2018

[Nav Experiment] Re-enable PasswordViewController egtests.

These test failures are not caused by SlimNav. Passing in the correct
flags allow them to pass with --enable-features=SlimNavigationManager.

Bug:  904885 
Change-Id: I1d45cd4c68aedd478a04bf02830e2223424b92ba
Reviewed-on: https://chromium-review.googlesource.com/c/1336056
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608121}
[modify] https://crrev.com/ca0515b5a9c85095044fb5aaf367d077fdc388f7/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm

Comment 4 by danyao@chromium.org, Nov 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment