Create a System health story for SERP->AMP page |
||
Issue descriptionMetric we are interested in is the .pc tick (https://github.com/ampproject/amphtml/blob/master/extensions/amp-viewer-integration/TICKEVENTS.md) Need to figure out how to read this in telemetry. Implementation Steps: 1) Turn the .pc tick into a metric that telemetry knows about a) Get it into the trace events with mark and measure (blink.console filter category) i) Investigate the amp implementation and see if we can add it if they aren't already using mark/measure ii) Inject the mark/measure javascript in the page through the benchmark b) Write a new metric to process the events and measure the value b) Add custom javascript execution to the benchmark to read the tick measurement values out of the page and create a value for them 2) Add a loading news story to the system_health mobile benchmark suite. We will load the search results for news and click on the new york times page which is an amp page. We will add the metric measurement to that benchmark.
,
Dec 18
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16dde34e140000
,
Dec 19
📍 Job complete. See results below. https://pinpoint-dot-chromeperf.appspot.com/job/16dde34e140000
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/161ea1266c42693334a27e47a6291936c67f01ce commit 161ea1266c42693334a27e47a6291936c67f01ce Author: Emily Hanley <eyaich@google.com> Date: Mon Jan 14 17:11:23 2019 Adding navigationId to the user timing events. This was needed in https://chromium-review.googlesource.com/c/catapult/+/1379733 to correlate the right amp pc mark with its navigation event. Bug: 904879 Change-Id: I8b643619c56f55b7104c23554a00061c3cfd5712 Reviewed-on: https://chromium-review.googlesource.com/c/1401271 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#622487} [modify] https://crrev.com/161ea1266c42693334a27e47a6291936c67f01ce/base/trace_event/common/trace_event_common.h [modify] https://crrev.com/161ea1266c42693334a27e47a6291936c67f01ce/third_party/blink/renderer/core/timing/performance_timing.cc [modify] https://crrev.com/161ea1266c42693334a27e47a6291936c67f01ce/third_party/blink/renderer/core/timing/performance_timing.h [modify] https://crrev.com/161ea1266c42693334a27e47a6291936c67f01ce/third_party/blink/renderer/core/timing/performance_user_timing.cc
,
Jan 14
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/8eb35ff49bd8fabcc8a54daf37a19354fc3e7e75 commit 8eb35ff49bd8fabcc8a54daf37a19354fc3e7e75 Author: Emily Hanley <eyaich@google.com> Date: Mon Jan 14 18:46:58 2019 Adding timeToFirstViewportReady metric Will not be populated until https://github.com/ampproject/amphtml/pull/19918 is integrated Bug: chromium:904879 Change-Id: I2aedc4ac0402ecd982c1d76be40aef47c011442e Reviewed-on: https://chromium-review.googlesource.com/c/1379733 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> [modify] https://crrev.com/8eb35ff49bd8fabcc8a54daf37a19354fc3e7e75/tracing/tracing/metrics/system_health/loading_metric_test.html [modify] https://crrev.com/8eb35ff49bd8fabcc8a54daf37a19354fc3e7e75/tracing/tracing/metrics/system_health/loading_metric.html
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0770b08d637ba01c78bf1f17bac3cd6fd45ccbc0 commit 0770b08d637ba01c78bf1f17bac3cd6fd45ccbc0 Author: Emily Hanley <eyaich@google.com> Date: Mon Jan 14 19:52:40 2019 Adding a system health story for an amp page. Bug: 904879 Change-Id: Ie026a4b03b3cbbd327ca5d2eee88f56c8d13ed9e Reviewed-on: https://chromium-review.googlesource.com/c/1380334 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#622556} [modify] https://crrev.com/0770b08d637ba01c78bf1f17bac3cd6fd45ccbc0/tools/perf/page_sets/data/system_health_mobile.json [add] https://crrev.com/0770b08d637ba01c78bf1f17bac3cd6fd45ccbc0/tools/perf/page_sets/data/system_health_mobile_0483ae239d.wprgo.sha1 [modify] https://crrev.com/0770b08d637ba01c78bf1f17bac3cd6fd45ccbc0/tools/perf/page_sets/system_health/browsing_stories.py
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9d39cb7402e371e19d1485f07270953c266d4cd commit c9d39cb7402e371e19d1485f07270953c266d4cd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Jan 16 02:43:37 2019 Roll src/third_party/catapult 96320b515106..78448d90081e (17 commits) https://chromium.googlesource.com/catapult.git/+log/96320b515106..78448d90081e git log 96320b515106..78448d90081e --date=short --no-merges --format='%ad %ae %s' 2019-01-15 vollick@chromium.org Plumb the trace buffer size for atrace 2019-01-15 perezju@chromium.org Revert "[py_utils] Add modules_util.RequireVersion" 2019-01-15 taylori@google.com Fix handling of perfetto protobuf on mac 2019-01-15 perezju@chromium.org [dashboard] Remove dead code in start_try_job.py 2019-01-15 perezju@chromium.org Revert "Remove TagMap." 2019-01-15 perezju@chromium.org [Telemetry] Add list_of_scalar_values.mean 2019-01-15 dtu@chromium.org [pinpoint] Add Tags field to try job dialog. 2019-01-15 dtu@chromium.org [pinpoint] Ignore cached isolate hashes over 8 weeks old. 2019-01-14 eroman@chromium.org Fix import of new NetExport generated logs. 2019-01-14 bsheedy@chromium.org Fix gtest conversion multiplier 2019-01-14 eyaich@google.com Adding timeToFirstViewportReady metric 2019-01-14 perezju@chromium.org [py_utils] Add modules_util.RequireVersion 2019-01-14 perezju@chromium.org Remove GetNetworkData methods 2019-01-14 perezju@chromium.org [cli services] Add buildbucket_service 2019-01-14 perezju@chromium.org [Telemetry] Remove TBMv1 metrics.SmoothnessMetric 2019-01-11 benjhayden@chromium.org Remove TagMap. 2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON. Created with: gclient setdep -r src/third_party/catapult@78448d90081e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:776709,chromium:777865,chromium:918218,chromium:921616,chromium:874940,chromium:916877, chromium:917273 ,chromium:921342,chromium:904879,chromium:776709,chromium:777865,chromium:480512, chromium:919093 , chromium:691581 ,chromium:921000,chromium:918218,chromium:918208 TBR=sullivan@chromium.org Change-Id: I75c07d8719f5668f9b4a95a9757cf6c25412b547 Reviewed-on: https://chromium-review.googlesource.com/c/1413252 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623062} [modify] https://crrev.com/c9d39cb7402e371e19d1485f07270953c266d4cd/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by nedngu...@google.com
, Nov 13