Flaky test: PreviewsLitePageServerBrowserTest.LitePagePreviewsNavigation Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4865 Test output log: https://chromium-swarm.appspot.com/task?id=412624b5e7452010 Culprit (70.0% confidence): r607427 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyygELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKTAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNDg2NS9icm93c2VyX3Rlc3RzIG9uIFVidW50dS0xNi4wNC9VSEpsZG1sbGQzTk1hWFJsVUdGblpWTmxjblpsY2tKeWIzZHpaWEpVWlhOMExreHBkR1ZRWVdkbFVISmxkbWxsZDNOT1lYWnBaMkYwYVc5dQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PreviewsLitePageServerBrowserTest.LitePagePreviewsNavigation&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyygELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKTAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNDg2NS9icm93c2VyX3Rlc3RzIG9uIFVidW50dS0xNi4wNC9VSEpsZG1sbGQzTk1hWFJsVUdGblpWTmxjblpsY2tKeWIzZHpaWEpVWlhOMExreHBkR1ZRWVdkbFVISmxkbWxsZDNOT1lYWnBaMkYwYVc5dQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Reverting https://chromium-review.googlesource.com/c/chromium/src/+/1323800 (via https://chromium-review.googlesource.com/c/chromium/src/+/1333814).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de commit 1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 13 16:33:41 2018 Revert "Integrate Lite Page Server Previews with the Previews Stack" This reverts commit 8bd3e513b8595b1a0651c716e51c151dbd1fa4e2. Reason for revert: identified as likely cause for flakyness of PreviewsLitePageServerBrowserTest.LitePagePreviewsNavigation by FindIt Original change's description: > Integrate Lite Page Server Previews with the Previews Stack > > Adds Lite Page Server Previews to DetermineAllowedPreviews and > DetermineCommitted. For now, the preview is always allowed if the > feature is enabled and is committed if the URL matches. > > This intentionally leaves an open question about whether more logic > in the NavigationThrottle can/should be moved into the DeciderImpl. > > The biggest part of this change is moving the URL checking logic to > the previews component and adding additional helper functions there. > > Bug: 898557 > Change-Id: Iccc0b672eeedbe23942f4d17f6afd214426372a9 > Reviewed-on: https://chromium-review.googlesource.com/c/1323800 > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607427} TBR=dougarnett@chromium.org,robertogden@chromium.org Change-Id: Iaa200e39f10086d95654bc7fb7485c66d3f53ed0 No-Presubmit: true No-Tree-Checks: true Bug: 898557, 904830 Reviewed-on: https://chromium-review.googlesource.com/c/1333814 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607613} [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/android/previews_android_bridge.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/previews_lite_page_browsertest.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/previews_lite_page_decider.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/previews_lite_page_navigation_throttle.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/previews_lite_page_navigation_throttle.h [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/previews_lite_page_navigation_throttle_unittest.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/previews_ui_tab_helper.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/chrome/browser/previews/previews_ui_tab_helper_unittest.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/components/previews/content/previews_content_util.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/components/previews/content/previews_content_util_unittest.cc [modify] https://crrev.com/1e3e82ceefc3ed9bf7aea3c7ebcbc5e5111e91de/components/previews/core/BUILD.gn [delete] https://crrev.com/f3f15d41dd781e8cf6370f544c2356c1cd627213/components/previews/core/previews_lite_page_url_handler.cc [delete] https://crrev.com/f3f15d41dd781e8cf6370f544c2356c1cd627213/components/previews/core/previews_lite_page_url_handler.h [delete] https://crrev.com/f3f15d41dd781e8cf6370f544c2356c1cd627213/components/previews/core/previews_lite_page_url_handler_unittest.cc
Comment 1 by sdefresne@chromium.org
, Nov 13