Issue 904828 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Nov 21
Cc:	mlamouri@chromium.org
Components:	Blink>Media>PictureInPicture
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	3
Type:	Bug

Tab crashes when document.exitPictureInPicture is called if PiP video is in shadow dom

Project Member Reported by fbeaufort@chromium.org, Nov 13

Issue description

Looking at a debug build when calling document.exitPictureInPicture() when a video is already in Picture-in-Picture, a DCHECK failed.

  DCHECK(IsHTMLVideoElement(picture_in_picture_element));

Source: https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/modules/picture_in_picture/document_picture_in_picture.cc#47

WIP at https://chromium-review.googlesource.com/c/chromium/src/+/1333769

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dea3e1ef15cb10052e5d7d62993fe7d9a11e87b

commit 5dea3e1ef15cb10052e5d7d62993fe7d9a11e87b
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Nov 13 18:16:39 2018

[Picture-in-Picture] Fix shadow dom crash when exiting PiP.

This CL fixes a tab crash that occurs when calling document.exitPictureInPicture()
if a video in a shadow DOM is already in Picture-in-Picture.

Bug:  904828 

Change-Id: I6aed0fa43dd0af1406d4349509101d423f622d96
Reviewed-on: https://chromium-review.googlesource.com/c/1333769
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#607658}
[modify] https://crrev.com/5dea3e1ef15cb10052e5d7d62993fe7d9a11e87b/third_party/WebKit/LayoutTests/external/wpt/picture-in-picture/shadow-dom.html
[modify] https://crrev.com/5dea3e1ef15cb10052e5d7d62993fe7d9a11e87b/third_party/blink/renderer/modules/picture_in_picture/document_picture_in_picture.cc
[modify] https://crrev.com/5dea3e1ef15cb10052e5d7d62993fe7d9a11e87b/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/5dea3e1ef15cb10052e5d7d62993fe7d9a11e87b/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h

Comment 2 by fbeaufort@chromium.org, Nov 21

Status: Fixed (was: Started)

►

Issue 904828 link

Issue metadata

Tab crashes when document.exitPictureInPicture is called if PiP video is in shadow dom

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 13

Comment 1 Deleted

Comment 2 by fbeaufort@chromium.org, Nov 21

Comment 2 Deleted

Sign in to add a comment