New issue
Advanced search Search tips

Issue 904827 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Clank - convert errors with null messages into UNKNOWN_ERROR

Project Member Reported by kpaulhamus@google.com, Nov 13

Issue description

The FIDO modules in APS v24 returns error codes with null messages, causing Canary crashes:

11-12 15:29:52.353 24599 24599 E AndroidRuntime: java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=1000, result=-1, data=Intent { (has extras) }} to activity {com.chrome.canary/com.google.android.apps.chrome.Main}: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference

The code where this fails:
https://cs.corp.google.com/clank/java/src/com/google/android/apps/chrome/webauth/Fido2CredentialRequest.java?type=cs&q=+package:%5Eclank$+lang:java+fido2request&g=0&l=264
 
(Found during APS v24 development testing - GmsCore's integration hasn't happened yet)
Labels: -Pri-0 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2789a7ebfacc9c5453d59c6401164fe4f750d2ac

commit 2789a7ebfacc9c5453d59c6401164fe4f750d2ac
Author: Kim Paulhamus <kpaulhamus@google.com>
Date: Wed Dec 12 00:10:32 2018

Status: Fixed (was: Assigned)

Sign in to add a comment