New issue
Advanced search Search tips

Issue 904818 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clean up completed fetches in BackgroundFetchDelegateImpl

Project Member Reported by rayankans@google.com, Nov 13

Issue description

We keep the job details around in memory in case updateUI will be called. We should have a way of knowing when to clean up a completed fetch.
 
Owner: rayankans@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6175923cdbc5973d8206f12491b9cb1f96d3c4

commit ed6175923cdbc5973d8206f12491b9cb1f96d3c4
Author: Rayan Kanso <rayankans@google.com>
Date: Wed Nov 14 18:08:53 2018

[Background Fetch] Delete all in-memory fetch data

Inform upstream systems when a fetch is completely finished (event
dispatch is complete) to know that it's safe to remove in-memory
fetch data.

Bug:  904818 
Change-Id: Ieef3ff87ce66e97f177ef8422994adb22568e155
Reviewed-on: https://chromium-review.googlesource.com/c/1333815
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608033}
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/browser/background_fetch/background_fetch_delegate_proxy.h
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/browser/background_fetch/background_fetch_scheduler.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/browser/background_fetch/mock_background_fetch_delegate.h
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/public/browser/background_fetch_delegate.h
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/shell/browser/layout_test/layout_test_background_fetch_delegate.cc
[modify] https://crrev.com/ed6175923cdbc5973d8206f12491b9cb1f96d3c4/content/shell/browser/layout_test/layout_test_background_fetch_delegate.h

Status: Fixed (was: Started)

Sign in to add a comment