New issue
Advanced search Search tips

Issue 904805 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 906116



Sign in to add a comment

Summation should serialize percentage before dimension

Project Member Reported by futhark@chromium.org, Nov 13

Issue description

According to: https://drafts.csswg.org/css-values-4/#math-function-serialize-a-summation

This test is failing:

external/wpt/css/css-transforms/transforms-support-calc.html

 
I'd like to take this issue.
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Owner: ericwilligers@chromium.org
Status: Started (was: Available)
Sorry, I already started working on this
https://chromium-review.googlesource.com/c/chromium/src/+/1341289

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60e2c0cc39b289e9a0c23557ca952348c2bc7630

commit 60e2c0cc39b289e9a0c23557ca952348c2bc7630
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Mon Nov 19 13:19:08 2018

CSS: Serialize % before px in calc

https://drafts.csswg.org/css-values/#math-function-serialize-a-summation
Percentage should be serialized before dimensions with units

Also fix typo in WPTs svg/geometry/parsing/*-computed.svg
calc(50% + 60x) becomes calc(50% + 60px)

BUG=904805

Change-Id: I2ecb732564c405f9315a1ef06e5bd0777c407f19
Reviewed-on: https://chromium-review.googlesource.com/c/1341289
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609262}
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/animations/custom-properties/custom-length-percentage-list-type-interpolation-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/animations/custom-properties/custom-length-percentage-list-type-interpolation.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/animations/interpolation/border-image-width-interpolation-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-shapeMargin.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-to-style-change.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/css3/calc/getComputedStyle-border-radius-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/css3/calc/getComputedStyle-border-radius.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/css3/calc/getComputedStyle-calc-assert.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/css3/flexbox/flex-property-parsing-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/css3/flexbox/flex-property-parsing.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-align/gaps/column-gap-parsing-001.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-align/gaps/gap-parsing-001.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-align/gaps/grid-column-gap-parsing-001.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-align/gaps/grid-gap-parsing-001.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-align/gaps/grid-row-gap-parsing-001.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-align/gaps/row-gap-parsing-001.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/registered-property-interpolation-004.https.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-paint-api/registered-property-value-009.https.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/registered-property-computation.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/registered-property-initial.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-margin-003-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-010-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-011-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-010-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-011-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-inset-008-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-inset-009-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-polygon-006-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/transforms-support-calc-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/translate-getComputedStyle.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/css/motion/offset-supports-calc.html
[delete] https://crrev.com/df208483bc8b82a226a4adb7fbdbc25999f60f2d/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/cx-computed-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/cx-computed.svg
[delete] https://crrev.com/df208483bc8b82a226a4adb7fbdbc25999f60f2d/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/cy-computed-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/cy-computed.svg
[delete] https://crrev.com/df208483bc8b82a226a4adb7fbdbc25999f60f2d/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/r-computed-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/r-computed.svg
[delete] https://crrev.com/df208483bc8b82a226a4adb7fbdbc25999f60f2d/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/rx-computed-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/rx-computed.svg
[delete] https://crrev.com/df208483bc8b82a226a4adb7fbdbc25999f60f2d/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/ry-computed-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/ry-computed.svg
[delete] https://crrev.com/df208483bc8b82a226a4adb7fbdbc25999f60f2d/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/x-computed-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/x-computed.svg
[delete] https://crrev.com/df208483bc8b82a226a4adb7fbdbc25999f60f2d/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/y-computed-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/geometry/parsing/y-computed.svg
[add] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/painting/parsing/stroke-width-computed.svg
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/svg/painting/parsing/stroke-width-valid.svg
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/property-types.js
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position-calc-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/css/parsing-object-position-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/css/parsing-object-position.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/shapes/parsing/parsing-shape-margin-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/shapes/parsing/parsing-shape-margin.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/WebKit/LayoutTests/transforms/translate-parsing.html
[modify] https://crrev.com/60e2c0cc39b289e9a0c23557ca952348c2bc7630/third_party/blink/renderer/core/css/css_calculation_value.cc

Blocking: 906116

Sign in to add a comment