Confirm no-op failing on Windows builders. |
||||
Issue descriptionStarting on this build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Win%20x64%20Builder/20848 With this error message: ninja explain: output obj/third_party/blink/renderer/core/css/css/text_decoration_skip_ink_custom.obj older than most recent input gen/third_party/blink/renderer/core/css/properties/longhands/text_decoration_skip_ink.h (563806852 vs 563809655) ninja explain: obj/third_party/blink/renderer/core/css/css/text_decoration_skip_ink_custom.obj is dirty ninja explain: obj/third_party/blink/renderer/core/css/css.lib is dirty ninja explain: v8_context_snapshot_generator.exe is dirty ninja explain: v8_context_snapshot.bin is dirty ninja explain: obj/tools/v8_context_snapshot/generate_v8_context_snapshot.stamp is dirty ninja explain: obj/third_party/blink/renderer/core/css/css.lib is dirty ninja explain: obj/third_party/blink/renderer/core/css/css.lib is dirty ninja explain: browser_tests.exe is dirty Culprit is obviously https://chromium-review.googlesource.com/c/1333095 because the commit modifies a template for a code generator. This points to a missing dependency somewhere. The problem is that css/properties/longhands/text_decoration_skip_ink.h is not referenced as an output in make_core_generated_css_longhand_property_classes. I'll fix this, but someone that knows Blink should make code generators check that the list of outputs is correct.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72551008d755933990eb68d241d86ac97399ca06 commit 72551008d755933990eb68d241d86ac97399ca06 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Nov 13 12:39:43 2018 Fix missing output in Blink CSS code generator. make_core_generated_css_longhand_property_classes was missing text_decoration_skip_ink.h as an output. BUG= chromium:904788 TBR=tkent@chromium.org Change-Id: I4144bb975f647dd01ea2277b02cef4528f2c9c23 Reviewed-on: https://chromium-review.googlesource.com/c/1333389 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607566} [modify] https://crrev.com/72551008d755933990eb68d241d86ac97399ca06/third_party/blink/renderer/core/BUILD.gn
,
Nov 13
,
Nov 13
,
Nov 13
Fantastic work Corentin tracking this down and fixing it rapidly! |
||||
►
Sign in to add a comment |
||||
Comment 1 by cwallez@chromium.org
, Nov 13