As far as I know, this "experiment" flag should always be true. Removing it should also expose some dead code in invalidations, see invalidations::prefs::kInvalidationServiceUseGCMChannel
I've checked that the server never sets this, so it's always true (by default).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39c24c8550d19ff106a2040c582689920ed322eb commit 39c24c8550d19ff106a2040c582689920ed322eb Author: Marc Treib <treib@chromium.org> Date: Mon Nov 19 11:39:18 2018 Sync cleanup: Remove Experiments::gcm_invalidations_enabled It's always true. Bug: 904782 Change-Id: I6cb979f5e168a33d100b3dfda00257f5d72438b5 Reviewed-on: https://chromium-review.googlesource.com/c/1341533 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609242} [modify] https://crrev.com/39c24c8550d19ff106a2040c582689920ed322eb/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/39c24c8550d19ff106a2040c582689920ed322eb/components/invalidation/impl/invalidation_prefs.cc [modify] https://crrev.com/39c24c8550d19ff106a2040c582689920ed322eb/components/sync/base/experiments.h [modify] https://crrev.com/39c24c8550d19ff106a2040c582689920ed322eb/components/sync/engine_impl/sync_manager_impl.cc [modify] https://crrev.com/39c24c8550d19ff106a2040c582689920ed322eb/components/sync/protocol/experiments_specifics.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c600c1b4ec0a1b45152c38e85aa9409131902c8 commit 4c600c1b4ec0a1b45152c38e85aa9409131902c8 Author: Marc Treib <treib@chromium.org> Date: Mon Nov 19 12:59:35 2018 Remove invalidation::prefs::kInvalidationServiceUseGCMChannel It's always true in practice. Unfortunately, the pre-GCM code is still not quite dead: The ChromeOS-only TiclDeviceSettingsProvider still says to *not* use the GCM channel by default. Bug: 904782 Change-Id: I904db5088bd0e869343b8acf5bbb62cc7047c300 Reviewed-on: https://chromium-review.googlesource.com/c/1341831 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609255} [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/invalidation/impl/invalidation_prefs.cc [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/invalidation/impl/invalidation_prefs.h [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/invalidation/impl/invalidation_switches.cc [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/invalidation/impl/invalidation_switches.h [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/invalidation/impl/profile_invalidation_provider.cc [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/invalidation/impl/ticl_profile_settings_provider.cc [modify] https://crrev.com/4c600c1b4ec0a1b45152c38e85aa9409131902c8/components/invalidation/impl/ticl_profile_settings_provider_unittest.cc
Comment 1 by mastiz@chromium.org
, Nov 16