contextual suggestions service not work. |
||
Issue descriptionChrome Version: None OS: Android It seems not a bug of Chrome app because seems the app I installed in my phone does not run into this code (https://cs.chromium.org/chromium/src/components/omnibox/browser/contextual_suggestions_service.cc?q=contextual_suggestions_service.cc&sq=package:chromium&dr&l=246), but seems this code misses cookies while sending request to google suggest server because by default URLLoader does not attach cookies.
,
Nov 13
,
Nov 13
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec2fc8ad1a2b9075fa315b46a3af834174981676 commit ec2fc8ad1a2b9075fa315b46a3af834174981676 Author: Pengcheng <pengcheng@google.com> Date: Tue Nov 27 15:45:54 2018 Attach cookies while requesting for suggestions. By default SimpleURLLoader does not attach cookies while sending request, but for contextual suggestion service, the auth cookies are required, otherwise it responses empty result. Bug: 904742 Change-Id: I6d061c859cda9804fe7372634aae5c5d46916ea1 Reviewed-on: https://chromium-review.googlesource.com/c/1333017 Commit-Queue: Pengcheng Xu <pengcheng@google.com> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611118} [modify] https://crrev.com/ec2fc8ad1a2b9075fa315b46a3af834174981676/components/omnibox/browser/BUILD.gn [modify] https://crrev.com/ec2fc8ad1a2b9075fa315b46a3af834174981676/components/omnibox/browser/contextual_suggestions_service.cc [add] https://crrev.com/ec2fc8ad1a2b9075fa315b46a3af834174981676/components/omnibox/browser/contextual_suggestions_service_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by mpear...@chromium.org
, Nov 13