New issue
Advanced search Search tips

Issue 904732 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Nov 16
Cc:
maruel@google.com
vadimsh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

shellcheck tests hang on Windows

Project Member Reported by no...@chromium.org, Nov 13 
tricium spellcheck tests hang since https://chromium-review.googlesource.com/c/1330974

first hanging build: https://ci.chromium.org/p/infra-internal/builders/luci.infra-internal.prod/infra-packager-win-32/2911

This blocks kitchen rollout (for lucicon)

alternatively, can we disable these tests?

Comment 1 by iannu...@google.com, Nov 13 

disabling tests sgtm
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/53cbe5a573414d6e128961bd44ddf619b60a1a0b

commit 53cbe5a573414d6e128961bd44ddf619b60a1a0b
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 07:42:50 2018

[tricium] Disable spellcheck on Windows

R=iannucci@chromium.org
TBR=maruel@chromium.org, qyearsley@chromium.org

Bug:  904732 
Change-Id: I6e67ca13b616dfb2f3ec34ba6bdec8ca80cdc538
Reviewed-on: https://chromium-review.googlesource.com/c/1332804
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18954}
[modify] https://crrev.com/53cbe5a573414d6e128961bd44ddf619b60a1a0b/go/src/infra/tricium/functions/spellchecker/spellchecker_test.go

Comment 3 by no...@chromium.org, Nov 13

Cc: -qyears...@chromium.org vadimsh@chromium.org
Labels: -Pri-0 Pri-3
Owner: qyears...@chromium.org
Quinten, PTAL when convenient

Comment 4 by vadimsh@chromium.org, Nov 13 

I wonder why it didn't hang on the presubmit builder...
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f6eca9992af0a4ae2c226ff1c5890997b1697cca

commit f6eca9992af0a4ae2c226ff1c5890997b1697cca
Author: Nodir Turakulov <nodir@chromium.org>
Date: Tue Nov 13 17:36:07 2018

Revert "[tricium] Disable spellcheck on Windows"

This reverts commit 53cbe5a573414d6e128961bd44ddf619b60a1a0b.

Reason for revert: this CL disabled a wrong. Correct CL: https://chromium-review.googlesource.com/c/infra/infra/+/1333689/

Original change's description:
> [tricium] Disable spellcheck on Windows
> 
> R=​iannucci@chromium.org
> TBR=maruel@chromium.org, qyearsley@chromium.org
> 
> Bug:  904732 
> Change-Id: I6e67ca13b616dfb2f3ec34ba6bdec8ca80cdc538
> Reviewed-on: https://chromium-review.googlesource.com/c/1332804
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Auto-Submit: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#18954}

TBR=maruel@chromium.org,iannucci@chromium.org,qyearsley@chromium.org,nodir@chromium.org

Change-Id: Id3551a5b4639913537aa1fab4947e3d8347d2094
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  904732 
Reviewed-on: https://chromium-review.googlesource.com/c/1334127
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18961}
[modify] https://crrev.com/f6eca9992af0a4ae2c226ff1c5890997b1697cca/go/src/infra/tricium/functions/spellchecker/spellchecker_test.go
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a7c7e3f5c9707baae478476e6afd11def6c6286d

commit a7c7e3f5c9707baae478476e6afd11def6c6286d
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 13 17:42:55 2018

[tricium] Disable shellcheck on Windows

TBR=maruel@chromium.org, qyearsley@chromium.org

Bug:  904732 
Change-Id: I20d77ffb53b7a13817032e512118a213a7fd2569
Reviewed-on: https://chromium-review.googlesource.com/c/1333689
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18962}
[modify] https://crrev.com/a7c7e3f5c9707baae478476e6afd11def6c6286d/go/src/infra/tricium/functions/shellcheck/main_test.go

Comment 7 by qyears...@chromium.org, Nov 16

Summary: shellcheck tests hang on Windows (was: spellcheck tests hang)
Is keeping the test disabled OK indefinitely? I'm assuming we never need to run the shellcheck analyzer code on Windows, and thus we don't want/need to run the tests on Windows either.

Comment 8 by mar...@chromium.org, Nov 16 

Fair enough. I guess you can close the issue.

Comment 9 by qyears...@chromium.org, Nov 16

Status: Fixed (was: Assigned)
►

Sign in to add a comment