New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904728 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 874698



Sign in to add a comment

Anomaly doesn't seem collected to crash/ since some version

Project Member Reported by f...@chromium.org, Nov 13

Issue description

Crash console link for searches:

https://crash.corp.google.com/browse?q=product_name%3D%27ChromeOS%27+AND+EXISTS+%28SELECT+1+FROM+UNNEST%28productdata%29+WHERE+Key%3D%27exec_name%27+AND+%28Value%3D%27selinux-violation%27+OR+Value%3D%27kernel-warning%27%29%29+AND+%28product.Version%3D%2711210.0.0%27+OR+product.Version%3D%2711125.0.0%27+OR+product.Version%3D%2711097.0.0%27+OR+product.Version%3D%2711151.11.0%27+OR+product.Version%3D%2711021.56.0%27%29#-propertyselector,-productname:1000,+productversion,stablesignature:50


Search exec_name = 'selinux-violation' OR exec_name = 'kernel-warning' (generally fake "crashes" collected by anomaly_collector)


Dev branch: 11097.0.0 (has reports) -> 11125.0.0 (no reports) -> 11210.0.0 (current, no reports)
Beta branch: 11056.0.0 (has reports) -> 11151.11.0 (no reports) -> 11151.17.0 (current, no reports)

Version number to search are from chrome release blog.

 
Labels: -Pri-3 Pri-1
selinux-violation can be understandable since vapier@ disabled it temporarily for workarounding some test.

but kernel-warning is still disappearing from crash/ (unless all of them get fixed between 11097.0.0 and 11125.0.0)

oh, selinux-violation is also not understandable. The reverts after fixing the test landed more than 1 months ago, and is already in 11210.0.0 according to crosland/

Typo in beta branch version number.
s/11056.0.0/11021.56.0/


Labels: -Restrict-View-EditIssue OS-Chrome
it's because anomaly_collector runs in a unique/reduced mount namespace and doesn't have access to /home/chronos/ which has the 'Consent To Send Stats' file.  so whenever it checks to see if consent has been granted, it returns false.

another good reason to move this consent file out of the login profile dir :).
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e10d08244d96fbc170703514a73baf8bb45288b3

commit e10d08244d96fbc170703514a73baf8bb45288b3
Author: Qijiang Fan <fqj@chromium.org>
Date: Fri Nov 16 23:10:58 2018

crash: bind-mount /var/lib/whitelist and /home/chronos

crash_reporter running inside anomaly_collector minijail will need to
read device policy from /var/lib/whitelist, and user consent from
/home/chronos.

BUG= chromium:904728 
TEST=rm /root/.leave_core and anomalies are collected.

Change-Id: I7ce04836e991b357105b18696e5c85b62830b7f1
Reviewed-on: https://chromium-review.googlesource.com/1337191
Commit-Ready: Qijiang Fan <fqj@chromium.org>
Tested-by: Qijiang Fan <fqj@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e10d08244d96fbc170703514a73baf8bb45288b3/crash-reporter/init/anomaly-collector.conf

Blocking: 874698
Labels: Merge-Request-71 M-71
Owner: f...@chromium.org
Status: Started (was: Untriaged)
looks like the breaking change started in R71, so only one branch to backport to
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 17

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approved for M71 ChromeOS
Labels: -Merge-Approved-71 Merge-Merged
Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 19

Labels: merge-merged-release-R71-11151.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a64182d0b405e43f759b11f7099e7d2f55e2c3d7

commit a64182d0b405e43f759b11f7099e7d2f55e2c3d7
Author: Qijiang Fan <fqj@chromium.org>
Date: Mon Nov 19 22:21:25 2018

crash: bind-mount /var/lib/whitelist and /home/chronos

crash_reporter running inside anomaly_collector minijail will need to
read device policy from /var/lib/whitelist, and user consent from
/home/chronos.

BUG= chromium:904728 
TEST=rm /root/.leave_core and anomalies are collected.

Change-Id: I7ce04836e991b357105b18696e5c85b62830b7f1
(cherry picked from commit e10d08244d96fbc170703514a73baf8bb45288b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1340753
Reviewed-by: Qijiang Fan <fqj@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a64182d0b405e43f759b11f7099e7d2f55e2c3d7/crash-reporter/init/anomaly-collector.conf

I had to dig up the dates.

2018-09-27 03:33 R71-11105.0.0 last successful canary send 
2018-09-28 03:15 R71-11108.0.0 when this broke with https://chromium.googlesource.com/chromiumos/platform2/+/5bb6ad4c07299b88eeb7d9a17b10cbc2d4c4ed27
R72-11271.0.0 first successful send of crash.


Sign in to add a comment